Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-03 Thread Jerin Jacob
On Mon, Feb 3, 2020 at 2:44 PM Gaetan Rivet wrote: > > On 02/02/2020 12:21, Jerin Jacob wrote: > > On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger > > wrote: > >> > >> On Fri, 31 Jan 2020 22:31:57 +0530 > >> wrote: > >> > >>> + > >>> +#define set_err(err, where, fmt, ...) do {

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-03 Thread Gaetan Rivet
On 02/02/2020 12:21, Jerin Jacob wrote: On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger wrote: On Fri, 31 Jan 2020 22:31:57 +0530 wrote: + +#define set_err(err, where, fmt, ...) do { \ + graph_err(fmt, ##__VA_ARGS__);

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Jerin Jacob
On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger wrote: > > On Fri, 31 Jan 2020 22:31:57 +0530 > wrote: > > > + > > +#define set_err(err, where, fmt, ...) do { > > \ > > + graph_err(fmt, ##__VA_ARGS__); > > \ > > +

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Jerin Jacob
On Sun, Feb 2, 2020 at 4:05 PM Stephen Hemminger wrote: > > On Fri, 31 Jan 2020 22:31:57 +0530 > wrote: > > > + /* Create graph object */ > > + graph = calloc(1, sizeof(*graph)); > > + if (graph == NULL) > > + set_err(ENOMEM, fail, "failed to calloc graph object"); > > Thi

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + > +#define set_err(err, where, fmt, ...) do { \ > + graph_err(fmt, ##__VA_ARGS__); \ > + rte_errno = err; \ > +

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + /* Create graph object */ > + graph = calloc(1, sizeof(*graph)); > + if (graph == NULL) > + set_err(ENOMEM, fail, "failed to calloc graph object"); This won't be safe if used in primary/secondary process model. You would need

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + /* Create graph object */ > + graph = calloc(1, sizeof(*graph)); > + if (graph == NULL) > + set_err(ENOMEM, fail, "failed to calloc graph object"); T

[dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-01-31 Thread jerinj
From: Jerin Jacob Abstracting the data processing functions as “nodes” and “link” them together to create complex “graph” to enable reusable data processing functions has been identified as proven architecture. Introducing the graph infrastructure for packet processing. Signed-off-by: Jerin Jac