Re: [dpdk-dev] L3fwd mode in testpmd

2021-08-02 Thread Dharmik Thakkar
Hi, Kathleen has submitted an RFC patch [1] in this regard. We’d appreciate your comments. [1] https://patches.dpdk.org/project/dpdk/patch/20210430213747.41530-2-kathleen.cape...@arm.com/ Thank you! > On Apr 30, 2021, at 4:28 AM, Ananyev, Konstantin > wrote: > >> >> >> On Thu, Apr 29, 2021

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-30 Thread Ananyev, Konstantin
> > On Thu, Apr 29, 2021 at 11:47:30AM +, Ananyev, Konstantin wrote: > > > > > > > It looks as if implementing em_mask_key() is enough to get l3fwd > > > working. However to me this ifdef seems tricky. How should a scalar > > > implementation handle the xmm_t type? rte_xmm_t looks like an A

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-29 Thread Stanislaw Kardach
On Thu, Apr 29, 2021 at 11:47:30AM +, Ananyev, Konstantin wrote: > > > > It looks as if implementing em_mask_key() is enough to get l3fwd > > working. However to me this ifdef seems tricky. How should a scalar > > implementation handle the xmm_t type? rte_xmm_t looks like an API > > type/unio

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-29 Thread Ananyev, Konstantin
> > On Thu, Apr 29, 2021 at 08:31:03AM +, Ananyev, Konstantin wrote: > > Hi Stanislaw, > > > > > > > > On Wed, Apr 28, 2021 at 09:44:54PM +, Honnappa Nagarahalli wrote: > > > > > > > [Honnappa] Sorry, I do not understand this. I see that vector code is > > > > under compile time flag a

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-29 Thread Stanislaw Kardach
On Thu, Apr 29, 2021 at 08:31:03AM +, Ananyev, Konstantin wrote: > Hi Stanislaw, > > > > > On Wed, Apr 28, 2021 at 09:44:54PM +, Honnappa Nagarahalli wrote: > > > > > [Honnappa] Sorry, I do not understand this. I see that vector code is > > > under compile time flag as below > > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-29 Thread Ananyev, Konstantin
Hi Stanislaw, > > On Wed, Apr 28, 2021 at 09:44:54PM +, Honnappa Nagarahalli wrote: > > > [Honnappa] Sorry, I do not understand this. I see that vector code is under > > compile time flag as below > > > > #if defined RTE_ARCH_X86 || defined __ARM_NEON > > l3fwd_em_se

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-29 Thread Stanislaw Kardach
On Wed, Apr 28, 2021 at 09:44:54PM +, Honnappa Nagarahalli wrote: > [Honnappa] Sorry, I do not understand this. I see that vector code is under > compile time flag as below > > #if defined RTE_ARCH_X86 || defined __ARM_NEON > l3fwd_em_send_packets(nb_rx, pkts_burst, >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Honnappa Nagarahalli
> > > > > > > > > In fact, l3fwd is also quite big and complex: > > > $ wc -l examples/l3fwd/*.[h,c] |grep total > > > 6969 total > > > > > > Plus it will introduce extra dependencies (fib, lpm, hash, might-be > > > acl?) I am not sure it is a good idea to pull all these complexities into > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Honnappa Nagarahalli
On Wed, Apr 28, 2021 at 12:48 PM Bruce Richardson mailto:bruce.richard...@intel.com>> wrote: > I do not suggest pulling all these in. In our case, I see that the ask is > only on LPM. I am open to hearing what others see as the requirement. > I think fib is the planned long-term replacement fo

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Thomas Monjalon
28/04/2021 13:04, Stanisław Kardach: > On Wed, Apr 28, 2021 at 12:48 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > > > > > I do not suggest pulling all these in. In our case, I see that the ask > > is only on LPM. I am open to hearing what others see as the requirement. > > > > > I

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Thomas Monjalon
28/04/2021 12:48, Bruce Richardson: > On Tue, Apr 27, 2021 at 11:17:24PM +, Honnappa Nagarahalli wrote: > > > Yes, this is what we have done. It is a new forwarding mode. > > We could remove some forwarding modes from testpmd. For ex: macfwd, macswap > > seem very similar to iofwd mode. > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Stanisław Kardach
On Wed, Apr 28, 2021 at 12:48 PM Bruce Richardson < bruce.richard...@intel.com> wrote: > > I do not suggest pulling all these in. In our case, I see that the ask > is only on LPM. I am open to hearing what others see as the requirement. > > > I think fib is the planned long-term replacement for l

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Ananyev, Konstantin
> > > > > > > > > > > > On Tue, 27 Apr 2021 10:50:20 +0100 > > > > Ferruh Yigit wrote: > > > > > > > > > Agree that it may help testing to have l3fwd support on the testpmd. > > > > > > > > > > Two concerns, > > > > > 1) Testpmd already too complex. > > > > > 2) Code duplication. > > > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Ananyev, Konstantin
> > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > wrote: > > > > > > > > Hello, > > > > Performance of L3fwd example application is one > > > > of the key > > > benchmarks in DPDK. How

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-28 Thread Bruce Richardson
On Tue, Apr 27, 2021 at 11:17:24PM +, Honnappa Nagarahalli wrote: > Yes, this is what we have done. It is a new forwarding mode. > We could remove some forwarding modes from testpmd. For ex: macfwd, macswap > seem very similar to iofwd mode. I'd suggest removing one of those two, but not bot

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Honnappa Nagarahalli
> > > > > This discussion has ended up as a stats discussion. But, we also need > to be able to change the configurable parameters easily. > > > > > If we implement the stats and ability to change the configurable > > > > > parameters, then it is essentially bringing in some of the > > > > > capa

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Honnappa Nagarahalli
> > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > wrote: > > > > > > Hello, > > > Performance of L3fwd example application is one > > > of the key > > benchmarks in DPDK. However, the appli

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Honnappa Nagarahalli
> > > > > > > On Tue, 27 Apr 2021 10:50:20 +0100 > > > Ferruh Yigit wrote: > > > > > > > Agree that it may help testing to have l3fwd support on the testpmd. > > > > > > > > Two concerns, > > > > 1) Testpmd already too complex. > > > > 2) Code duplication. > > > > > > > > For 1), if the l3fwd c

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Ananyev, Konstantin
> > > > On Tue, 27 Apr 2021 10:50:20 +0100 > > Ferruh Yigit wrote: > > > > > Agree that it may help testing to have l3fwd support on the testpmd. > > > > > > Two concerns, > > > 1) Testpmd already too complex. > > > 2) Code duplication. > > > > > > For 1), if the l3fwd can be implemented in test

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Honnappa Nagarahalli
> > On Tue, 27 Apr 2021 10:50:20 +0100 > Ferruh Yigit wrote: > > > Agree that it may help testing to have l3fwd support on the testpmd. > > > > Two concerns, > > 1) Testpmd already too complex. > > 2) Code duplication. > > > > For 1), if the l3fwd can be implemented in testpmd as new, independ

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Stephen Hemminger
On Tue, 27 Apr 2021 10:50:20 +0100 Ferruh Yigit wrote: > Agree that it may help testing to have l3fwd support on the testpmd. > > Two concerns, > 1) Testpmd already too complex. > 2) Code duplication. > > For 1), if the l3fwd can be implemented in testpmd as new, independent > forwarding mode,

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Bruce Richardson
On Tue, Apr 27, 2021 at 01:11:43PM +0200, Thomas Monjalon wrote: > 27/04/2021 11:57, Ananyev, Konstantin: > > From: Yigit, Ferruh > > > On 4/26/2021 9:46 PM, Honnappa Nagarahalli wrote: > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa > > > Nagarahalli wrote: > > > >>

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Thomas Monjalon
27/04/2021 11:57, Ananyev, Konstantin: > From: Yigit, Ferruh > > On 4/26/2021 9:46 PM, Honnappa Nagarahalli wrote: > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa > > Nagarahalli wrote: > > > > > > Hello, > > > Performance of L3f

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Ananyev, Konstantin
> david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; hemant.agra...@nxp.com; > Ananyev, Konstantin ; > Stephen Hemminger ; nd > Subject: Re: [dpdk-dev] L3fwd mode in testpmd > > On 4/26/2021 9:46 PM, Honnappa Nagarahalli wrote: > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Ferruh Yigit
On 4/26/2021 9:46 PM, Honnappa Nagarahalli wrote: > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli wrote: > > Hello, > Performance of L3fwd example application > is one of the key benchma

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-27 Thread Andrew Rybchenko
On 4/26/21 11:46 PM, Honnappa Nagarahalli wrote: > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli wrote: > > Hello, > Performance of L3fwd example application > is one of the key benchmar

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa > > > > > > > > > > > Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > Performance of L3fwd example application > > > > > > > > > > > > is one of the key > > > > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Honnappa Nagarahalli
> > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > Performance of L3fwd example application is > > > > > > > > > > > one of the key > > > > > > > > > > benchmarks in

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Stephen Hemminger
On Mon, 26 Apr 2021 15:14:59 +0530 Jerin Jacob wrote: > On Sat, Apr 24, 2021 at 5:56 AM Honnappa Nagarahalli > wrote: > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > Hello, > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Jerin Jacob
On Sat, Apr 24, 2021 at 5:56 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > Performance of L3fwd example application is one > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-23 Thread Honnappa Nagarahalli
> > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > Performance of L3fwd example application is one > > > > > > > > > of the key > > > > > > > > benchmarks in DPDK. However, the applicat

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Jerin Jacob
On Thu, Apr 1, 2021 at 5:51 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > wrote: > > > > > > > > > > > > > > > > Hello, > > > > > > > > Performance of L3fwd example application is one of > > > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Honnappa Nagarahalli
> > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > wrote: > > > > > > > > > > > > > > Hello, > > > > > > > Performance of L3fwd example application is one of > > > > > > > the key > > > > > > benchmarks in DPDK. However, the application does not hav

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Jerin Jacob
gt; > ; Dharmik Thakkar > > ; Ruifeng Wang ; > > david.march...@redhat.com; Bruce Richardson > > ; jer...@marvell.com; > > hemant.agra...@nxp.com; Ferruh Yigit ; Ananyev, > > Konstantin ; Stephen Hemminger > > ; nd ; nd > > Subject: RE: [dpdk-dev] L3fwd mo

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Kathleen Capella
n > ; jer...@marvell.com; > hemant.agra...@nxp.com; Ferruh Yigit ; Ananyev, > Konstantin ; Stephen Hemminger > ; nd ; nd > Subject: RE: [dpdk-dev] L3fwd mode in testpmd > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagara

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Honnappa Nagarahalli
> > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > wrote: > > > > > > > > Hello, > > > > Performance of L3fwd example application is one of the key > > > benchmarks in DPDK. However, the application does not have many > > > debugging statistics to understand the

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Thomas Monjalon
11/03/2021 16:18, Honnappa Nagarahalli: > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > wrote: > > > > > > Hello, > > > Performance of L3fwd example application is one of the key > > benchmarks in DPDK. However, the application does not have many > > debugging stat

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-11 Thread Honnappa Nagarahalli
> > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > wrote: > > > > Hello, > > Performance of L3fwd example application is one of the key > benchmarks in DPDK. However, the application does not have many > debugging statistics to understand the performance issues. We have added >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-10 Thread Jerin Jacob
On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli wrote: > > Hello, > Performance of L3fwd example application is one of the key benchmarks > in DPDK. However, the application does not have many debugging statistics to > understand the performance issues. We have added L3fwd as anoth

[dpdk-dev] L3fwd mode in testpmd

2021-03-10 Thread Honnappa Nagarahalli
Hello, Performance of L3fwd example application is one of the key benchmarks in DPDK. However, the application does not have many debugging statistics to understand the performance issues. We have added L3fwd as another mode/stream to testpmd which provides enough statistics at various l