Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-19 Thread David Marchand
On Wed, Dec 19, 2018 at 1:39 PM Neil Horman wrote: > On Wed, Dec 19, 2018 at 10:12:06AM +0100, David Marchand wrote: > > On Tue, Dec 18, 2018 at 1:27 PM David Marchand < > david.march...@redhat.com> > > wrote: > > But my script still needs some work to make it lighter... > > A fresh build went fr

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-19 Thread Neil Horman
On Wed, Dec 19, 2018 at 10:12:06AM +0100, David Marchand wrote: > On Tue, Dec 18, 2018 at 1:27 PM David Marchand > wrote: > > > > > On Tue, Dec 18, 2018 at 1:25 PM Neil Horman wrote: > > > >> On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: > >> > >> > The real issue in the end is

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-19 Thread David Marchand
On Tue, Dec 18, 2018 at 1:27 PM David Marchand wrote: > > On Tue, Dec 18, 2018 at 1:25 PM Neil Horman wrote: > >> On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: >> >> > The real issue in the end is that the __rte_experimental in headers is >> the >> > most important thing and ca

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 1:25 PM Neil Horman wrote: > On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: > > > The real issue in the end is that the __rte_experimental in headers is > the > > most important thing and can be missed during reviews. > > But I found no easy way to detect

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-18 Thread Neil Horman
On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: > On Wed, Dec 5, 2018 at 2:22 PM David Marchand > wrote: > > > > > On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote: > > > >> On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: > >> > On Tue, Dec 4, 2018 at 4:16 PM Neil

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-18 Thread David Marchand
On Wed, Dec 5, 2018 at 2:22 PM David Marchand wrote: > > On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote: > >> On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: >> > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman >> wrote: >> > > If you would like to make this adjustment, I'm fine wi

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-05 Thread David Marchand
On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote: > On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: > > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman > wrote: > > > If you would like to make this adjustment, I'm fine with it, though be > > > aware, > > > you will likely need to make

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-05 Thread Neil Horman
On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman wrote: > > > On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > > > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman > > wrote: > > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100,

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread Richardson, Bruce
-dev] Marking symbols as experimental in the headers > only > > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman wrote: > > > On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > > > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman > > wrote: > > > &

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread David Marchand
On Tue, Dec 4, 2018 at 4:16 PM Neil Horman wrote: > On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman > wrote: > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > > I would say, give it a try, and if you can demon

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread Neil Horman
On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman wrote: > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > > Hello Neil, > > > > > > Looking at > > > > > http://doc.dpdk.org/guides/contributing/versioning.html#expe

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread David Marchand
On Mon, Dec 3, 2018 at 5:48 PM Neil Horman wrote: > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > Hello Neil, > > > > Looking at > > > http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis, > > is there a real need to mark both the definition and the decl

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-03 Thread Neil Horman
On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > Hello Neil, > > Looking at > http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis, > is there a real need to mark both the definition and the declaration of a > symbol with the __rte_experimental marker ? > Whe

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-03 Thread Ferruh Yigit
On 12/3/2018 1:01 PM, David Marchand wrote: > Hello Neil, > > Looking at > http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis, > is there a real need to mark both the definition and the declaration of a > symbol with the __rte_experimental marker ? > > My understanding is t

[dpdk-dev] Marking symbols as experimental in the headers only

2018-12-03 Thread David Marchand
Hello Neil, Looking at http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis, is there a real need to mark both the definition and the declaration of a symbol with the __rte_experimental marker ? My understanding is that the whole point of having this marker is so that rte_com