Re: [dpdk-dev] Misuses of dev_info->if_index in embedded drivers.

2020-08-24 Thread Hemant Agrawal
> -Original Message- > From: Ferruh Yigit > Sent: Monday, August 24, 2020 8:49 PM > To: Stephen Hemminger ; Hemant Agrawal > ; Sachin Saxena > Cc: dev@dpdk.org; Gagandeep Singh ; Akhil Goyal > > Subject: Re: [dpdk-dev] Misuses of dev_info->if_index in emb

Re: [dpdk-dev] Misuses of dev_info->if_index in embedded drivers.

2020-08-24 Thread Ferruh Yigit
On 8/24/2020 4:07 PM, Stephen Hemminger wrote: > The use of if_index in some drivers is wrong. > It does not match the user expectation in the documentation. > > This code: > dpaa2/dpaa2_ethdev.c: dev_info->if_index = priv->hw_id; > pfe/pfe_ethdev.c: dev_info->if_index = internals->id; >

[dpdk-dev] Misuses of dev_info->if_index in embedded drivers.

2020-08-24 Thread Stephen Hemminger
The use of if_index in some drivers is wrong. It does not match the user expectation in the documentation. This code: dpaa2/dpaa2_ethdev.c: dev_info->if_index = priv->hw_id; pfe/pfe_ethdev.c: dev_info->if_index = internals->id; Does match: struct rte_eth_dev_info { struct rte_devi