Re: [dpdk-dev] Suggestion to improve the code review

2020-06-03 Thread Jerin Jacob
On Wed, Jun 3, 2020 at 6:39 PM Ferruh Yigit wrote: > > On 6/2/2020 5:23 PM, Jerin Jacob wrote: > > On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: > >> > >> On 6/2/2020 1:27 PM, Jerin Jacob wrote: > >>> On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > > On 27/05/20 09:28 +,

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-03 Thread Ferruh Yigit
On 6/2/2020 5:23 PM, Jerin Jacob wrote: > On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: >> >> On 6/2/2020 1:27 PM, Jerin Jacob wrote: >>> On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > I think, original discussion[1] on

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Jerin Jacob
On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: > > On 6/2/2020 1:27 PM, Jerin Jacob wrote: > > On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > >> > >> On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > >>> I think, original discussion[1] on this topic got lost in GitHub vs > >>> cur

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Ferruh Yigit
On 6/2/2020 1:27 PM, Jerin Jacob wrote: > On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: >> >> On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: >>> I think, original discussion[1] on this topic got lost in GitHub vs current >>> workflow. >>> >>> >>> I would like to propose GitHub "CODEOWN

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Jerin Jacob
On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > > On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > > I think, original discussion[1] on this topic got lost in GitHub vs current > > workflow. > > > > > > I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK > > workflow

Re: [dpdk-dev] Suggestion to improve the code review

2020-05-27 Thread Jerin Jacob
On Wed, May 27, 2020 at 3:29 PM Burakov, Anatoly wrote: > > On 27-May-20 10:28 AM, Jerin Kollanukkaran wrote: > > I think, original discussion[1] on this topic got lost in GitHub vs current > > workflow. > > > > > > I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK > > workfl

Re: [dpdk-dev] Suggestion to improve the code review

2020-05-27 Thread Gaëtan Rivet
On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > I think, original discussion[1] on this topic got lost in GitHub vs current > workflow. > > > I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK > workflow. > > Current scheme: > - When we submit a patch to ml, someone(Tr

Re: [dpdk-dev] Suggestion to improve the code review

2020-05-27 Thread Burakov, Anatoly
On 27-May-20 10:28 AM, Jerin Kollanukkaran wrote: I think, original discussion[1] on this topic got lost in GitHub vs current workflow. I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK workflow. Current scheme: - When we submit a patch to ml, someone(Tree maintainer[3]) n

[dpdk-dev] Suggestion to improve the code review

2020-05-27 Thread Jerin Kollanukkaran
I think, original discussion[1] on this topic got lost in GitHub vs current workflow. I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK workflow. Current scheme: - When we submit a patch to ml, someone(Tree maintainer[3]) needs to manually delegate the patch to Tree maintain