Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-11 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, October 10, 2019 5:37 PM > > > -Original Message- > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Thursday, October 10, 2019 8:30 AM > > > > > -

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-10 Thread Ananyev, Konstantin
> -Original Message- > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, October 10, 2019 8:30 AM > To: Stephen Hemminger > Cc: Ananyev, Konstantin ; dpdk-dev > ; Jerin Jacob > Subject: RE: [dpdk-dev] packet data access bug

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-10 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, October 9, 2019 7:25 PM > > On Wed, 9 Oct 2019 17:20:58 +0200 > Morten Brørup wrote: > > > > -Original Message- > > > From: Stephen Hemminger [mailto:step...@networkpl

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 17:20:58 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, October 9, 2019 5:15 PM > > > > On Wed, 9 Oct 2019 17:06:24 +0200 > > Morten Brørup wrote: > > > > > > -Original Mess

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 9, 2019 5:15 PM > > On Wed, 9 Oct 2019 17:06:24 +0200 > Morten Brørup wrote: > > > > -Original Message- > > > From: Stephen Hemminger [mailto:step...@networkplumber.org]

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 17:06:24 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, October 9, 2019 5:02 PM > > > > On Wed, 9 Oct 2019 11:11:46 + > > "Ananyev, Konstantin" wrote: > > > > > Hi Morten, >

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 9, 2019 5:02 PM > > On Wed, 9 Oct 2019 11:11:46 + > "Ananyev, Konstantin" wrote: > > > Hi Morten, > > > > > > > > Hi Konstantin and Stephen, > > > > > > I just noticed the sa

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 11:11:46 + "Ananyev, Konstantin" wrote: > Hi Morten, > > > > > Hi Konstantin and Stephen, > > > > I just noticed the same bug in your bpf and pcap libraries: > > > > You are using rte_pktmbuf_mtod(), but should be using rte_pktmbuf_read(). > > Otherwise you cannot read

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Wednesday, October 9, 2019 1:12 PM > > Hi Morten, > > > > > Hi Konstantin and Stephen, > > > > I just noticed the same bug in your bpf and pcap libraries: > > > > You are using rte_pk

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Ananyev, Konstantin
Hi Morten, > > Hi Konstantin and Stephen, > > I just noticed the same bug in your bpf and pcap libraries: > > You are using rte_pktmbuf_mtod(), but should be using rte_pktmbuf_read(). > Otherwise you cannot read data across multiple segments. In plain data buffer mode expected input for BPF p

[dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
Hi Konstantin and Stephen, I just noticed the same bug in your bpf and pcap libraries: You are using rte_pktmbuf_mtod(), but should be using rte_pktmbuf_read(). Otherwise you cannot read data across multiple segments. Med venlig hilsen / kind regards - Morten Brørup