Re: [dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Thomas Monjalon
06/04/2020 14:37, Dmitry Kozlyuk: > > Lastly, in the patch you implemented functions that were common for Linux > > and FreeBSD and in order to use them in Windows (e.g. eal_file_truncate > > that replaced ftruncate) and you got a duplicate code for Linux and > > FreeBSD, how can we solve this d

Re: [dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Dmitry Kozlyuk
Hi, > In the "eal/windows: fix rte_page_sizes with Clang on Windows" > (http://patches.dpdk.org/patch/67390/) patch I didn't understand the work > around that you did and what the problem was. Clang on Windows always uses uint32_t as an underlying type for enums. As a consequence, rte_hugepage_

[dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Fady Bader
Hi, I have a few questions regarding your memory management patch. In the "eal/windows: fix rte_page_sizes with Clang on Windows" (http://patches.dpdk.org/patch/67390/) patch I didn't understand the work around that you did and what the problem was. Regarding rte_mp functions I see you implemente