Hi.

I'm looking at implementing rte_event_dev_xstats_by_name() for DSW, and I have some API-related questions.

Shouldn't rte_event_dev_xstats_by_name_get() return mode and queue/port id? Otherwise the caller needs to know if the name refers to a device- or port-level stat, and in case of the latter also the port or queue id. That information is needed in subsequent rte_event_dev_xstats_get() call.

Also, the API states that the function may return "negative value: -EINVAL if stat not found, -ENOTSUP if not supported", which is somewhat misleading, since the return value is of an unsigned type.

Regards,
        Mattias

Reply via email to