Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Ananyev, Konstantin
> > > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > > functions - it is hard to maintain, the parameters are already > > > > > > > self-explanatory > > > > > > > 3) Files need som

Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Honnappa Nagarahalli
> > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > functions - it is hard to maintain, the parameters are already > > > > > > self-explanatory > > > > > > 3) Files need some re-org > > >

Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Ananyev, Konstantin
> > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > 1) Remove the detailed comments on top of the internal functions - > > > > > it is hard to maintain, the parameters are already > > > > > self-explanatory > > > > > 3) Files need some re-org > > > > >

Re: [dpdk-dev] rte_ring work

2020-05-07 Thread Honnappa Nagarahalli
> > > > > > Hi Honnappa, > > > > > > > > > > > Hi Konstantin, > > > > Just to make sure we are coordinating the work on rte_ring, I > > > > plan to get the following things done for 20.08. Please let me > > > > know if you have any > > > comments. > > > > > > Thanks for sharing your plans.

Re: [dpdk-dev] rte_ring work

2020-05-07 Thread Ananyev, Konstantin
> > > > Hi Honnappa, > > > > > > > > Hi Konstantin, > > > Just to make sure we are coordinating the work on rte_ring, I plan to > > > get the following things done for 20.08. Please let me know if you have > > > any > > comments. > > > > Thanks for sharing your plans. > > In general, looks reaso

Re: [dpdk-dev] rte_ring work

2020-05-07 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > > > > Hi Konstantin, > > Just to make sure we are coordinating the work on rte_ring, I plan to > > get the following things done for 20.08. Please let me know if you have any > comments. > > Thanks for sharing your plans. > In general, looks reasonable to me. > Few com

Re: [dpdk-dev] rte_ring work

2020-05-07 Thread Ananyev, Konstantin
Hi Honnappa, > > Hi Konstantin, > Just to make sure we are coordinating the work on rte_ring, I plan to > get the following things done for 20.08. Please let me know if > you have any comments. Thanks for sharing your plans. In general, looks reasonable to me. Few comments/questions below

[dpdk-dev] rte_ring work

2020-05-06 Thread Honnappa Nagarahalli
Hi Konstantin, Just to make sure we are coordinating the work on rte_ring, I plan to get the following things done for 20.08. Please let me know if you have any comments. 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been around for 2 releases now. 2) Make the legacy