[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-16 Thread Damjan Marion (damarion)
> On 15 Jul 2016, at 17:08, Thomas Monjalon > wrote: > > 2016-07-15 16:37, Thomas Monjalon: >> I will apply it with trivial changes suggested by Jan and >> the small needed changes that I describe below: >> >> 2016-07-14 20:03, Jan Viktorin: >>> On Thu, 14 Jul 2016 15:27:29 +0200 >>> damarion

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-16 Thread Damjan Marion (damarion)
> On 15 Jul 2016, at 12:09, Thomas Monjalon > wrote: > > 2016-07-15 09:54, Damjan Marion: >> So we don?t have much pending beside 2 patches for i40e which >> Jeff submitted yesterday and they will i guess need to wait for 16.11. > > Yes these i40e patches will probably have to wait 16.11. >

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-15 16:37, Thomas Monjalon: > I will apply it with trivial changes suggested by Jan and > the small needed changes that I describe below: > > 2016-07-14 20:03, Jan Viktorin: > > On Thu, 14 Jul 2016 15:27:29 +0200 > > damarion at cisco.com wrote: > > > --- /dev/null > > > +++ b/lib/librte_ea

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
I will apply it with trivial changes suggested by Jan and the small needed changes that I describe below: 2016-07-14 20:03, Jan Viktorin: > On Thu, 14 Jul 2016 15:27:29 +0200 > damarion at cisco.com wrote: > > --- /dev/null > > +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c [...] > > +uint8_t

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-15 09:54, Damjan Marion: > So we don?t have much pending beside 2 patches for i40e which > Jeff submitted yesterday and they will i guess need to wait for 16.11. Yes these i40e patches will probably have to wait 16.11. > Only one which I have on my mind is: > > https://git.fd.io/cgit/vp

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-14 22:20, Damjan Marion: > > > On 15 Jul 2016, at 00:06, Thomas Monjalon > > wrote: > > > > 2016-07-14 18:10, Damjan Marion: > >> Dear Jan, > >> > >> Thank you for your comments. A bit too much overhead to submit simple patch > >> so let?s forget about it. I will just add it as it is t

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Damjan Marion (damarion)
> On 15 Jul 2016, at 10:31, Thomas Monjalon > wrote: > > 2016-07-14 22:20, Damjan Marion: >> >>> On 15 Jul 2016, at 00:06, Thomas Monjalon >>> wrote: >>> >>> 2016-07-14 18:10, Damjan Marion: Dear Jan, Thank you for your comments. A bit too much overhead to submit simple patc

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-14 18:10, Damjan Marion: > Dear Jan, > > Thank you for your comments. A bit too much overhead to submit simple patch > so let?s forget about it. I will just add it as it is to our private > collection of patches. These are changes trivial to fix when applying. I strongly prefer that you u

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-14 Thread Damjan Marion (damarion)
> On 15 Jul 2016, at 00:06, Thomas Monjalon > wrote: > > 2016-07-14 18:10, Damjan Marion: >> Dear Jan, >> >> Thank you for your comments. A bit too much overhead to submit simple patch >> so let?s forget about it. I will just add it as it is to our private >> collection of patches. > > These

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-14 Thread Jan Viktorin
Hello Damjan, thank you for the patch. It makes sense to me. Next time, please CC the appropriate maintainers. (See the MAINTAINERS file in the root of the DPDK source tree.) In the subject after "spinlock:" you should start with a lower case letter, so "move constructor..." On Thu, 14 Jul 2016

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-14 Thread Damjan Marion (damarion)
Dear Jan, Thank you for your comments. A bit too much overhead to submit simple patch so let?s forget about it. I will just add it as it is to our private collection of patches. If anybody wants to pick it from here, please do... Thanks, Damjan > On 14 Jul 2016, at 20:03, Jan Viktorin wrote