Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-28 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, February 27, 2019 6:05 PM > To: Liu, Changpeng ; Ilya Maximets > ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Bie, Tiwei > ; Wang, Zhihong ; Jason Wang > > Subject: Re: vhost: add virtio conf

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Ilya Maximets
On 27.02.2019 12:04, Maxime Coquelin wrote: > > > On 2/26/19 3:07 PM, Ilya Maximets wrote: >> On 26.02.2019 16:43, Maxime Coquelin wrote: >>> >>> >>> On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: > > > On 2/26/19 9:42 AM, Ilya Maximets wrote

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/27/19 10:50 AM, Liu, Changpeng wrote: What we need to do is fix vhost lib so that you don't have anything to do in dpdk to add support for the new requests. So we need to fix the few bits in vhost_user_msg_handler() I mentionned yesterday. And I also notice we are missing rte_vhost_drive

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, February 27, 2019 5:12 PM > To: Liu, Changpeng ; Ilya Maximets > ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Bie, Tiwei > ; Wang, Zhihong ; Jason Wang > > Subject: Re: vhost: add virtio conf

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/27/19 2:31 AM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, February 26, 2019 8:32 PM To: Ilya Maximets ; Liu, Changpeng ; dev@dpdk.org Cc: Stojaczyk, Dariusz ; Bie, Tiwei ; Wang, Zhihong ; Jason Wang Subject

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/26/19 3:07 PM, Ilya Maximets wrote: On 26.02.2019 16:43, Maxime Coquelin wrote: On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- F

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Tiwei Bie
On Tue, Feb 26, 2019 at 01:32:24PM +0100, Maxime Coquelin wrote: > On 2/26/19 9:42 AM, Ilya Maximets wrote: > > On 26.02.2019 11:13, Liu, Changpeng wrote: > > > > > > > > > > -Original Message- > > > > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > > > > Sent: Tuesday, February 26,

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, February 26, 2019 8:32 PM > To: Ilya Maximets ; Liu, Changpeng > ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Bie, Tiwei > ; Wang, Zhihong ; Jason Wang > > Subject: Re: vhost: add virtio config

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Ilya Maximets
On 26.02.2019 16:43, Maxime Coquelin wrote: > > > On 2/26/19 2:36 PM, Ilya Maximets wrote: >> On 26.02.2019 15:32, Maxime Coquelin wrote: >>> >>> >>> On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: > > >> -Original Message- >> From:

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Maxime Coquelin
On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Ilya Maximets
On 26.02.2019 15:32, Maxime Coquelin wrote: > > > On 2/26/19 9:42 AM, Ilya Maximets wrote: >> On 26.02.2019 11:13, Liu, Changpeng wrote: >>> >>> -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39 PM To: Liu, Cha

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Maxime Coquelin
On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39 PM To: Liu, Changpeng ; dev@dpdk.org Cc: Stojaczyk, Dariusz ; maxime.coque...@redhat.com;

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Ilya Maximets
On 26.02.2019 11:13, Liu, Changpeng wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Tuesday, February 26, 2019 3:39 PM >> To: Liu, Changpeng ; dev@dpdk.org >> Cc: Stojaczyk, Dariusz ; >> maxime.coque...@redhat.com; Bie, Tiwei ; Wang, >> Zhi

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-26 Thread Liu, Changpeng
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 26, 2019 3:39 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jason Wang > Subject: Re: vhost: add virtio co

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Ilya Maximets
On 26.02.2019 10:01, Liu, Changpeng wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Monday, February 25, 2019 9:20 PM >> To: Liu, Changpeng ; dev@dpdk.org >> Cc: Stojaczyk, Dariusz ; >> maxime.coque...@redhat.com; Bie, Tiwei ; Wang, >> Zhih

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Liu, Changpeng
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, February 25, 2019 9:53 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jason Wang > Subject: Re: vhost: add virtio con

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Liu, Changpeng
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, February 25, 2019 9:20 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jason Wang > Subject: Re: vhost: add virtio con

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Ilya Maximets
On 25.02.2019 10:51, Changpeng Liu wrote: > This patch adds new vhost user messages GET_CONFIG and SET_CONFIG > used to get/set virtio device's PCI configuration space. > > Signed-off-by: Changpeng Liu > Reviewed-by: Darek Stojaczyk > --- > lib/librte_vhost/rte_vhost.h | 8 > lib/lib

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Ilya Maximets
On 25.02.2019 10:51, Changpeng Liu wrote: > This patch adds new vhost user messages GET_CONFIG and SET_CONFIG > used to get/set virtio device's PCI configuration space. Beside the fact that some additional description and reasoning required, I do not see the usage of this feature. You're defining