[dpdk-dev] xstats performance

2016-07-08 Thread Remy Horton
On 07/07/2016 23:59, Rasesh Mody wrote: [..] > We have submitted the QEDE and BNX2X PMD xstats patches with recent > API changes. Seen & Acked. > During the xstats change verification, it was observed that the order > in which xstats names are fetched don't seem to match the order in > which xs

[dpdk-dev] xstats performance

2016-07-07 Thread Rasesh Mody
> From: Remy Horton [mailto:remy.horton at intel.com] > Sent: Wednesday, July 06, 2016 12:44 AM > > > On 05/07/2016 19:10, Rasesh Mody wrote: > [..] > >> For all the current drivers xstats_names[idx].id==idx so it would > >> just involve removing the references to the id field and updating the >

[dpdk-dev] xstats performance

2016-07-06 Thread Remy Horton
On 05/07/2016 19:10, Rasesh Mody wrote: [..] >> For all the current drivers xstats_names[idx].id==idx so it would just >> involve removing the references to the id field and updating the >> documentation. Complication is coordinating with QLogic for the bnx2x & >> qede xstats patches. > > We could

[dpdk-dev] xstats performance

2016-07-05 Thread Rasesh Mody
Hi Remy, > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, July 01, 2016 2:15 AM > > > On 29/06/2016 17:40, Thomas Monjalon wrote: > [..] > > I don't think it is possible to standardize stats ids, for two reasons: > > - it is hard to maintain and avoid conflic

[dpdk-dev] xstats performance

2016-07-01 Thread Remy Horton
On 29/06/2016 17:40, Thomas Monjalon wrote: [..] > I don't think it is possible to standardize stats ids, for two reasons: > - it is hard to maintain and avoid conflicts between drivers > - the drivers would have to lookup the names which degrades performance I designed it that way to keep flexib

[dpdk-dev] xstats performance

2016-06-29 Thread Thomas Monjalon
2016-06-29 17:03, Remy Horton: > On 29/06/2016 16:38, Olivier MATZ wrote: > > And assume that the id field in rte_eth_xstat corresponds to > > the index in the rte_eth_xstat_name table? > > It was an assumption I wanted to avoid setting in stone, even though at > the moment it is actually true in

[dpdk-dev] xstats performance

2016-06-29 Thread Olivier MATZ
Hi Remy, While adapting an application to the new xstats API, I discovered that it may not be so efficient to display the statistics and their names. I think the test-pmd code illustrates the issue pretty well: /* Display xstats */ for (idx_xstat = 0; idx_xstat < cnt_xstats; idx_xstat++)

[dpdk-dev] xstats performance

2016-06-29 Thread Remy Horton
'noon, On 29/06/2016 16:38, Olivier MATZ wrote: [..] > And assume that the id field in rte_eth_xstat corresponds to > the index in the rte_eth_xstat_name table? It was an assumption I wanted to avoid setting in stone, even though at the moment it is actually true in implementation. The mapping