Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-11 Thread Kadam, Pallavi
On 8/9/2022 2:15 AM, Dmitry Kozlyuk wrote: 2022-08-08 17:33 (UTC-0700), Kadam, Pallavi: [...] Hi Pallavi, In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT` because only the first BAR slot of a 64-bit BAR contains flags. The current code has a state to track (curr_bar,

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-09 Thread Dmitry Kozlyuk
2022-08-08 17:33 (UTC-0700), Kadam, Pallavi: [...] > > Hi Pallavi, > > > > In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT` > > because only the first BAR slot of a 64-bit BAR contains flags. > > The current code has a state to track (curr_bar, prev_bar), > > and the fix

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-08 Thread Kadam, Pallavi
Hi Dmitry, On 8/6/2022 2:01 PM, Dmitry Kozlyuk wrote: 2022-08-02 12:10 (UTC-0700), Pallavi Kadam: For certain PCIe devices, BAR values are not continuous. This patch maps all the BARs and avoids skipping the next BAR addresses. Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driv

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-08 Thread Kadam, Pallavi
Hi Dmitry, On 8/6/2022 2:01 PM, Dmitry Kozlyuk wrote: 2022-08-02 12:10 (UTC-0700), Pallavi Kadam: For certain PCIe devices, BAR values are not continuous. This patch maps all the BARs and avoids skipping the next BAR addresses. Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driv

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-06 Thread Dmitry Kozlyuk
2022-08-02 12:10 (UTC-0700), Pallavi Kadam: > For certain PCIe devices, BAR values are not continuous. > This patch maps all the BARs and avoids skipping the next BAR addresses. > > Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driver") > Cc: navas...@microsoft.com > > Signed-off-

[dpdk-kmods] windows/netuio: fix bar parsing

2022-08-02 Thread Pallavi Kadam
For certain PCIe devices, BAR values are not continuous. This patch maps all the BARs and avoids skipping the next BAR addresses. Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driver") Cc: navas...@microsoft.com Signed-off-by: Qiao Liu Signed-off-by: Pallavi Kadam --- windows/n