Re: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-12 Thread fengchengwen
Hi Stephen, On 2024/4/11 23:05, Stephen Hemminger wrote: > On Thu, 11 Apr 2024 03:07:49 + > Chengwen Feng wrote: > >> Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), >> which will lead the hns3 NIC can't link up. The root cause is strict >> aliasing violation in rte_e

Re: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-11 Thread Stephen Hemminger
On Thu, 11 Apr 2024 03:07:49 + Chengwen Feng wrote: > Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), > which will lead the hns3 NIC can't link up. The root cause is strict > aliasing violation in rte_eth_linkstatus_set() with hns3 driver, see > [1] for more details. >

RE: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-11 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Thursday, 11 April 2024 13.58 [...] > Plus: yes, this patch mixes atomic and non-atomic access, but the main > reason is that we want to simplify the implementation. Yes, your design in patch v3 follows the current standard design pat

Re: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-11 Thread fengchengwen
Hi Morten, On 2024/4/11 14:58, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] >> Sent: Thursday, 11 April 2024 05.08 >> >> Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), >> which will lead the hns3 NIC can't link up. The root cause is strict >

RE: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-10 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Thursday, 11 April 2024 05.08 > > Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), > which will lead the hns3 NIC can't link up. The root cause is strict > aliasing violation in rte_eth_linkstatus_set() with hns3

RE: [PATCH] ethdev: fix strict aliasing lead to link cannot be up

2024-04-10 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Thursday, 11 April 2024 05.08 > > Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), > which will lead the hns3 NIC can't link up. The root cause is strict > aliasing violation in rte_eth_linkstatus_set() with hns3