On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct to avoid false sharing.
>
> RX struct happens to be 64 bytes on x86_64 already, so cache alignment
> makes no change there, but it does on 32-bit ISAs.
>
> TX struct is 56 bytes on x86_64.
>
Hi Mattias,
No obje
On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
Cache align Rx and Tx queue struct to avoid false sharing.
RX struct happens to be 64 bytes on x86_64 already, so cache alignment
makes no change there, but it does on 32-bit ISAs.
TX struct is 56 bytes on
> On Apr 23, 2024, at 3:56 PM, Mattias Rönnblom wrote:
>
> On 2024-04-23 13:15, Ferruh Yigit wrote:
>> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
>>> Cache align Rx and Tx queue struct to avoid false sharing.
>>>
>>> RX struct happens to be 64 bytes on x86_64 already, so cache alignment
>>
On 2024-04-24 02:27, Honnappa Nagarahalli wrote:
On Apr 23, 2024, at 3:56 PM, Mattias Rönnblom wrote:
On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
Cache align Rx and Tx queue struct to avoid false sharing.
RX struct happens to be 64 bytes on x86_
On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
> On 2024-04-23 13:15, Ferruh Yigit wrote:
>> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
>>> Cache align Rx and Tx queue struct to avoid false sharing.
>>>
>>> RX struct happens to be 64 bytes on x86_64 already, so cache alignment
>>> makes no chang
On Wed, Apr 24, 2024 at 11:21:52AM +0100, Ferruh Yigit wrote:
> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
> > On 2024-04-23 13:15, Ferruh Yigit wrote:
> >> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> >>> Cache align Rx and Tx queue struct to avoid false sharing.
> >>>
> >>> RX struct happe
On 2024-04-24 12:21, Ferruh Yigit wrote:
On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
Cache align Rx and Tx queue struct to avoid false sharing.
RX struct happens to be 64 bytes on x86_64 already, so cach
On 4/24/2024 12:57 PM, Mattias Rönnblom wrote:
> On 2024-04-24 12:21, Ferruh Yigit wrote:
>> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
>>> On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct to avoid false sharing
On 4/24/2024 11:28 AM, Bruce Richardson wrote:
> On Wed, Apr 24, 2024 at 11:21:52AM +0100, Ferruh Yigit wrote:
>> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
>>> On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct t
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
> > I don't know how slow af_packet is, but if you care about performance,
> > you don't want to use atomic add for statistics.
> >
>
> There are a few soft drivers already using atomics adds for updating stats.
> If we document expectati
On 2024-04-24 21:13, Stephen Hemminger wrote:
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
I don't know how slow af_packet is, but if you care about performance,
you don't want to use atomic add for statistics.
There are a few soft drivers already using atomics adds for updatin
On Thu, 25 Apr 2024 00:27:36 +0200
Mattias Rönnblom wrote:
> On 2024-04-24 21:13, Stephen Hemminger wrote:
> > On Wed, 24 Apr 2024 18:50:50 +0100
> > Ferruh Yigit wrote:
> >
> >>> I don't know how slow af_packet is, but if you care about performance,
> >>> you don't want to use atomic add for
On 2024-04-25 01:55, Stephen Hemminger wrote:
On Thu, 25 Apr 2024 00:27:36 +0200
Mattias Rönnblom wrote:
On 2024-04-24 21:13, Stephen Hemminger wrote:
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
I don't know how slow af_packet is, but if you care about performance,
you don't
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Thursday, 25 April 2024 11.26
>
> On 2024-04-25 01:55, Stephen Hemminger wrote:
> > On Thu, 25 Apr 2024 00:27:36 +0200
> > Mattias Rönnblom wrote:
> >
> >> On 2024-04-24 21:13, Stephen Hemminger wrote:
> >>> On Wed, 24 Apr 2024 18:50
On 4/25/2024 10:26 AM, Mattias Rönnblom wrote:
> On 2024-04-25 01:55, Stephen Hemminger wrote:
>> On Thu, 25 Apr 2024 00:27:36 +0200
>> Mattias Rönnblom wrote:
>>
>>> On 2024-04-24 21:13, Stephen Hemminger wrote:
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
>> I do
On 4/23/2024 12:15 PM, Ferruh Yigit wrote:
>> Signed-off-by: Mattias Rönnblom
>> ---
>> drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
>> b/drivers/net/af_packet/rte_eth_af_packe
On 2024-04-25 16:04, Ferruh Yigit wrote:
On 4/25/2024 10:26 AM, Mattias Rönnblom wrote:
On 2024-04-25 01:55, Stephen Hemminger wrote:
On Thu, 25 Apr 2024 00:27:36 +0200
Mattias Rönnblom wrote:
On 2024-04-24 21:13, Stephen Hemminger wrote:
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wro
On 2024-04-25 16:08, Ferruh Yigit wrote:
On 4/23/2024 12:15 PM, Ferruh Yigit wrote:
Signed-off-by: Mattias Rönnblom
---
drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/
On 4/25/2024 4:08 PM, Mattias Rönnblom wrote:
> On 2024-04-25 16:08, Ferruh Yigit wrote:
>> On 4/23/2024 12:15 PM, Ferruh Yigit wrote:
Signed-off-by: Mattias Rönnblom
---
drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
>>>
On 4/25/2024 4:06 PM, Mattias Rönnblom wrote:
> On 2024-04-25 16:04, Ferruh Yigit wrote:
>> On 4/25/2024 10:26 AM, Mattias Rönnblom wrote:
>>> On 2024-04-25 01:55, Stephen Hemminger wrote:
On Thu, 25 Apr 2024 00:27:36 +0200
Mattias Rönnblom wrote:
> On 2024-04-24 21:13, Stephen
On 2024-04-25 17:35, Ferruh Yigit wrote:
On 4/25/2024 4:08 PM, Mattias Rönnblom wrote:
On 2024-04-25 16:08, Ferruh Yigit wrote:
On 4/23/2024 12:15 PM, Ferruh Yigit wrote:
Signed-off-by: Mattias Rönnblom
---
drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--
1 file changed, 3 insertions
On 4/26/2024 8:38 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct to avoid false sharing.
>
> RX struct happens to be 64 bytes on x86_64 already, so cache alignment
> has no effect there, but it does on 32-bit ISAs.
>
> TX struct is 56 bytes on x86_64.
>
> Both structs keep coun
On 2024-04-26 10:27, Ferruh Yigit wrote:
On 4/26/2024 8:38 AM, Mattias Rönnblom wrote:
Cache align Rx and Tx queue struct to avoid false sharing.
RX struct happens to be 64 bytes on x86_64 already, so cache alignment
has no effect there, but it does on 32-bit ISAs.
TX struct is 56 bytes on x86
Recheck-request: iol-compile-amd64-testing
The DPDK Community Lab updated to the latest Alpine image yesterday, which
resulted in all Alpine builds failing. The failure is unrelated to your
patch, and this recheck should remove the fail on Patchwork, as we have
disabled Alpine testing for now.
24 matches
Mail list logo
