> Not sure if we want to do the same. Two reasons.
>
> 1. Searching the netvsc source, I don't see a place that it set
> hv->vlan_strip to
> false. It means !hv->vlan_string is always false, and rte_vlan_insert(&m)
> never
> run.
It's set here:
drivers/net/netvsc/hn_ethdev.c: hv->vlan_strip = !
> -Original Message-
> From: Long Li
> Sent: Saturday, February 10, 2024 2:48 AM
> To: Wei Hu ; ferruh.yi...@amd.com;
> andrew.rybche...@oktetlabs.ru; Thomas Monjalon
> ; Alan Elder
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 1/1] net/mana: add vlan tagging suppo
> -Original Message-
> From: Ferruh Yigit
> Sent: Saturday, February 10, 2024 12:06 AM
> To: Wei Hu ; andrew.rybche...@oktetlabs.ru; Thomas
> Monjalon ; Long Li
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/1] net/mana: add vlan tagging support
>
> On 2/9
> + if (oob->rx_vlan_tag_present) {
> + mbuf->ol_flags |=
> + RTE_MBUF_F_RX_VLAN |
> RTE_MBUF_F_RX_VLAN_STRIPPED;
> + mbuf->vlan_tci = oob->rx_vlan_id;
> + }
> +
Netvsc has the following code for dealing wi
On 2/9/2024 8:52 AM, Wei Hu wrote:
> For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx,
> extract vlan id from oob, put into mbuf and set the vlan flags in
> mbuf.
>
> Also add myself to the maintainers list for vmbus, mana and netvsc.
>
> Signed-off-by: Wei Hu
> ---
> MAINTAIN
5 matches
Mail list logo
