RE: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-14 Thread Loftus, Ciara
> > On Fri, 10 May 2024 10:03:57 + > Ciara Loftus wrote: > > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > > index fee0d5d5f3..968bbf6d45 100644 > > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > > @@ -

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-13 Thread Stephen Hemminger
On Mon, 13 May 2024 09:23:08 +0100 Maryam Tahhan wrote: > On 10/05/2024 16:06, Stephen Hemminger wrote: > > You don't have to use local statistic for this, there already is one in the > > dev struct > > i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port > > number to fin

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-13 Thread Maryam Tahhan
On 10/05/2024 16:06, Stephen Hemminger wrote: You don't have to use local statistic for this, there already is one in the dev struct i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find what dev is. I think the diff id that dev->data->rx_mbuf_alloc_failed

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-10 Thread Maryam Tahhan
On 10/05/2024 11:03, Ciara Loftus wrote: Failures to allocate mbufs in the receive path were not being accounted for in the ethdev statistics. Fix this. Bugzilla ID: 1429 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-by: C