RE: [PATCH 3/3] app/testpmd: fix meter mark handle update

2023-07-18 Thread Alexander Kozyrev
> On Tuesday, July 11, 2023 12:15 PM > Stephen Hemminger wrote: > On Tue, 11 Jul 2023 18:20:44 +0300 > Alexander Kozyrev wrote: > > > + case RTE_FLOW_ACTION_TYPE_METER_MARK: > > + rte_memcpy(&mtr_update.meter_mark, action->conf, > > + sizeof(struct rte_flow_action_m

Re: [PATCH 3/3] app/testpmd: fix meter mark handle update

2023-07-11 Thread Stephen Hemminger
On Tue, 11 Jul 2023 18:20:44 +0300 Alexander Kozyrev wrote: > + case RTE_FLOW_ACTION_TYPE_METER_MARK: > + rte_memcpy(&mtr_update.meter_mark, action->conf, > + sizeof(struct rte_flow_action_meter_mark)); Why use rte_memcpy? memcpy of fixed size is faster. Also,