Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-04 Thread Maxime Coquelin
On 11/4/22 04:52, Hernan Vargas wrote: Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Signed-off-by: Hernan Vargas ---

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, November 4, 2022 1:52 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 1/1] baseband/acc: fix ch

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-08 Thread Chautru, Nicolas
; From: Chautru, Nicolas > Sent: Friday, November 4, 2022 10:39 AM > To: Maxime Coquelin ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; > t...@redhat.com > Cc: Zhang, Qi Z > Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code > > Hi Maxime

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-10 Thread David Marchand
On Thu, Nov 3, 2022 at 8:57 PM Hernan Vargas wrote: > > Fix potential issue of dereferencing a pointer before null check. > Remove null check for value that could never be null. > > Coverity issue: 381646, 381631 > Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") > > Signed-off-b

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-10 Thread Chautru, Nicolas
TCH v1 1/1] baseband/acc: fix check after deref and dead code > > On Thu, Nov 3, 2022 at 8:57 PM Hernan Vargas > wrote: > > > > Fix potential issue of dereferencing a pointer before null check. > > Remove null check for value that could never be null. > > > > C

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-15 Thread Chautru, Nicolas
and ; Vargas, Hernan > > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; > maxime.coque...@redhat.com; Zhang, Qi Z > Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead > code > > Hi David, > > > -Original Message- > > From:

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-15 Thread David Marchand
Hello Nicolas, Hernan, On Thu, Nov 10, 2022 at 10:15 PM Chautru, Nicolas wrote: > > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c > > > b/drivers/baseband/acc/rte_acc100_pmd.c > > > index 96daef87bc..30a718916d 100644 > > > --- a/drivers/baseband/acc/rte_acc100_pmd.c > > > +++ b/drivers/ba

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-15 Thread Chautru, Nicolas
> Sent: Tuesday, November 15, 2022 8:00 AM > To: Chautru, Nicolas ; Vargas, Hernan > > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; > maxime.coque...@redhat.com; Zhang, Qi Z > Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead > code > > Hello

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-15 Thread Chautru, Nicolas
; gak...@marvell.com; t...@redhat.com; > maxime.coque...@redhat.com; Zhang, Qi Z > Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code > > Hi David, > I am not sure why the push back. The minimal and proper fix is that v1. > We are not making that check for other de

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2023-02-06 Thread Maxime Coquelin
On 1/20/23 21:55, Hernan Vargas wrote: Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Please Cc stable, since it fixes a