Looking at this patch because I have been alerted about the ABI compat handling.
I see some details that should have been caught in earlier reviews.
30/09/2022 20:46, Nicolas Chautru:
> +/*
> + * Maximum size to be used to manage the enum rte_bbdev_enqueue_status
> including padding for future
vell.com; maxime.coque...@redhat.com;
> t...@redhat.com; m...@ashroe.eu; Richardson, Bruce
> ; david.march...@redhat.com;
> step...@networkplumber.org; Zhang, Mingshan
> ; hemant.agra...@nxp.com
> Subject: Re: [PATCH v10 6/7] bbdev: add queue related warning and status
> information
03/10/2022 18:39, Chautru, Nicolas:
> Hi Thomas,
>
> I will update all your comments below today, thanks.
Please do a self review of other patches (I reviewed only this one),
I suspect there are a lot of other details to improve in other places.
> The one where we need your confirmation is spec
3 matches
Mail list logo