Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-27 Thread Jerin Jacob
On Thu, Jan 27, 2022 at 3:32 AM Alexander Kozyrev wrote: > > On Tuesday, January 25, 2022 13:44 Jerin Jacob wrote: > > On Tue, Jan 25, 2022 at 6:58 AM Alexander Kozyrev > > wrote: > > > > > > On Monday, January 24, 2022 12:41 Ajit Khaparde > > wrote: > > > > On Mon, Jan 24, 2022 at 6:37 AM Jeri

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Alexander Kozyrev
On Tuesday, January 25, 2022 13:44 Jerin Jacob wrote: > On Tue, Jan 25, 2022 at 6:58 AM Alexander Kozyrev > wrote: > > > > On Monday, January 24, 2022 12:41 Ajit Khaparde > wrote: > > > On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob > > > wrote: > > > > > > > Ok, I'll adopt this wording in the v3

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Ori Kam
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, January 26, 2022 3:41 PM > To: Ori Kam > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > On Wed, Jan 26, 2022 at 12:19:43PM +, Ori Kam wrote: > > >

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Bruce Richardson
On Wed, Jan 26, 2022 at 12:19:43PM +, Ori Kam wrote: > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, January 26, 2022 1:22 PM > > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > &g

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Ori Kam
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 26, 2022 1:22 PM > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > 26/01/2022 11:52, Bruce Richardson: > > The scenario is as follows. Suppose we have th

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Thomas Monjalon
26/01/2022 11:52, Bruce Richardson: > The scenario is as follows. Suppose we have the initial state as below: > > struct x_dev_cfg { >int x; > }; > > int > x_dev_cfg(int dev_id, struct x_dev_cfg *cfg) > { >struct x_dev *dev = x_devs[id]; >// some setup/config may go here >return d

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Bruce Richardson
On Wed, Jan 26, 2022 at 09:45:18AM +, Ori Kam wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, January 25, 2022 8:14 PM > > To: Ori Kam > > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hi

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-26 Thread Ori Kam
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, January 25, 2022 8:14 PM > To: Ori Kam > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > On Tue, Jan 25, 2022 at 06:09:42PM +, Bruce Richardson wrote: > > On

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 6:58 AM Alexander Kozyrev wrote: > > On Monday, January 24, 2022 12:41 Ajit Khaparde > wrote: > > On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob > > wrote: > > > > Ok, I'll adopt this wording in the v3. > > > > > + * > > > > + * @param port_id > > > > + * Port identifier

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Bruce Richardson
On Tue, Jan 25, 2022 at 06:09:42PM +, Bruce Richardson wrote: > On Tue, Jan 25, 2022 at 03:58:45PM +, Ori Kam wrote: > > Hi Bruce, > > > > > -Original Message- From: Bruce Richardson > > > Sent: Monday, January 24, 2022 8:09 PM > >

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Bruce Richardson
On Tue, Jan 25, 2022 at 03:58:45PM +, Ori Kam wrote: > Hi Bruce, > > > -Original Message- > > From: Bruce Richardson > > Sent: Monday, January 24, 2022 8:09 PM > > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > &g

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Ori Kam
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Monday, January 24, 2022 8:09 PM > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > > On Mon, Jan 24,

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
On Monday, January 24, 2022 12:41 Ajit Khaparde wrote: > On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob > wrote: > > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > wrote: > > > > > > The flow rules creation/destruction at a large scale incurs a performance > > > penalty and may negatively

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
On Monday, January 24, 2022 13:09 Bruce Richardson wrote: > On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > > On Mon, Jan 24, 2022 at 11:05 PM Thomas Monjalon > wrote: > > > > > > 24/01/2022 15:36, Jerin Jacob: > > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > wrote: >

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Alexander Kozyrev
Sorry, Ivan, missed your email last week since I wasn't in To list. Adding all the people back. On Wednesday, January 19, 2022 8:07 Ivan Malov wrote: > > +Rules management configuration > > +-- > > + > > +Configure flow rules management. > > It is either "managemen

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Bruce Richardson
On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > On Mon, Jan 24, 2022 at 11:05 PM Thomas Monjalon wrote: > > > > 24/01/2022 15:36, Jerin Jacob: > > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > > > wrote: > > > > +struct rte_flow_port_attr { > > > > + /** > > > > +

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Jerin Jacob
On Mon, Jan 24, 2022 at 11:05 PM Thomas Monjalon wrote: > > 24/01/2022 15:36, Jerin Jacob: > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev > > wrote: > > > +struct rte_flow_port_attr { > > > + /** > > > +* Version of the struct layout, should be 0. > > > +*/ > > > +

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Ajit Khaparde
On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob wrote: > > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev wrote: > > > > The flow rules creation/destruction at a large scale incurs a performance > > penalty and may negatively impact the packet processing when used > > as part of the datapath logic

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Thomas Monjalon
24/01/2022 15:36, Jerin Jacob: > On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev wrote: > > +struct rte_flow_port_attr { > > + /** > > +* Version of the struct layout, should be 0. > > +*/ > > + uint32_t version; > > Why version number? Across DPDK, we are using dyna

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-24 Thread Jerin Jacob
On Tue, Jan 18, 2022 at 9:01 PM Alexander Kozyrev wrote: > > The flow rules creation/destruction at a large scale incurs a performance > penalty and may negatively impact the packet processing when used > as part of the datapath logic. This is mainly because software/hardware > resources are alloc

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-19 Thread Ivan Malov
Hi, +Rules management configuration +-- + +Configure flow rules management. It is either "management OF ruleS" or "rule management". Perhaps fix similar occurrences across the series. + /** +* Number of counter actions pre-configured. +* If s