RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Jiawen Wu
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 1, 2024 10:46 AM > To: Jiawen Wu ; dev@dpdk.org > Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics > > On 11/1/2024 2:06 AM, Jiawen Wu wrote: >

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 2:06 AM, Jiawen Wu wrote: >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) >>> if (!txq->resetting) >>> continue; >>> >>> + txq->desc_error++; >>> >> >> Why error value is increased in this function, which resets the Tx queue?

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Jiawen Wu
> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) > > if (!txq->resetting) > > continue; > > > > + txq->desc_error++; > > > > Why error value is increased in this function, which resets the Tx queue? > Is the intention to reset the error va

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Count the number of packets not sent due to Tx descriptor error. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev.c | 6 ++ > drivers/net/txgbe/txgbe_rxtx.c | 3 +++ > drivers/net/txgbe/txgbe_rxtx.h | 1 + > 3 files changed, 10