15/12/2022 07:49, Jerin Jacob:
> On Wed, Dec 14, 2022 at 5:40 PM Ferruh Yigit wrote:
> >
> > On 12/14/2022 10:40 AM, Jerin Jacob wrote:
> > > On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote:
> > >> 4) Why we need to export trace point variables in the .map files,
> > >> like '__rte_eth_trace_a
On Wed, Dec 14, 2022 at 5:40 PM Ferruh Yigit wrote:
>
> On 12/14/2022 10:40 AM, Jerin Jacob wrote:
> > On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote:
> >>
> >> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
> >>
> >> Hi Ankur, Jerin,
> >
> > Hi Ferruh, Please find answers to generic trace questi
Hi Ferruh,
Thanks a lot for reviewing this patch. The generic questions have been answered
by Jerin in earlier email. I have replied inline to the remaining comments.
>
>There are bunch of small comments inline, some are related to above highlevel
>question.
>But I stopped after some point, speci
On 12/14/2022 10:40 AM, Jerin Jacob wrote:
> On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote:
>>
>> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
>>
>> Hi Ankur, Jerin,
>
> Hi Ferruh, Please find answers to generic trace questions.
>
>>
>> I have some major questions, I can see some already quer
On 12/14/2022 10:34 AM, David Marchand wrote:
> On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote:
>>
>> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
>>> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
>>> index 3651ceb234..79d0b2ee1f 100644
>>> --- a/lib/ethdev/version.map
>>> +++ b/l
On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote:
>
> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
>
> Hi Ankur, Jerin,
Hi Ferruh, Please find answers to generic trace questions.
>
> I have some major questions, I can see some already queried by Andrew as
> well:
>
> 1) How flexible are we on ch
On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote:
>
> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
> > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> > index 3651ceb234..79d0b2ee1f 100644
> > --- a/lib/ethdev/version.map
> > +++ b/lib/ethdev/version.map
> > @@ -319,4 +319,148 @@ IN
On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
Hi Ankur, Jerin,
I have some major questions, I can see some already queried by Andrew as
well:
1) How flexible are we on changing trace log output?
Should we take trace log as kind of user interface and don't break it
(as much as possible)? Or is it OK
On 10/6/2022 4:18 PM, Ankur Dwivedi wrote:
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index 3651ceb234..79d0b2ee1f 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -319,4 +319,148 @@ INTERNAL {
> rte_eth_representor_id_get;
> rte_eth_sw
On 10/10/2022 7:39 AM, Ankur Dwivedi wrote:
>> Yes the functions you mentioned in previous comment are called in while loop
>> in worker core. So I think they are fastpath.
>> rte_eth_stats_get() is called in fastpath. Similar to rte_eth_macaddr_get(),
>> I
>> think functions like
>> rte_eth_pro m
he...@oktetlabs.ru;
>jiawe...@trustnetic.com; jianw...@trustnetic.com; jbehr...@vmware.com;
>maxime.coque...@redhat.com; chenbo@intel.com;
>steven.webs...@windriver.com; matt.pet...@windriver.com;
>bruce.richard...@intel.com; mtetsu...@gmail.com; gr...@u256.net;
>jasvinder.si...@
Hi Morten,
>-Original Message-
>From: Ankur Dwivedi
>Sent: Thursday, October 6, 2022 8:49 PM
>To: dev@dpdk.org
>Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com;
>ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com;
>linvi...@tuxdriver.com; ciara.lof...@intel.com; qi.z.zh.
> From: Ankur Dwivedi [mailto:adwiv...@marvell.com]
> Sent: Thursday, 6 October 2022 17.19
>
> Add trace points for ethdev functions.
>
> Signed-off-by: Ankur Dwivedi
> ---
I did my best, but this series needs review by people with direct knowledge
about the affected functions.
rte_eth_call_r
13 matches
Mail list logo
