RE: [PATCH v3 2/4] eal: allow applications to report their cpu cycles usage

2022-12-07 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Wednesday, 7 December 2022 12.01 > > Hi Mattias, > > Mattias Rönnblom, Nov 29, 2022 at 17:10: > > > + * @param [out] busy_cycles > > > + * The number of busy CPU cycles since the application start. > > > > Wouldn't it be more appropriate to

Re: [PATCH v3 2/4] eal: allow applications to report their cpu cycles usage

2022-12-07 Thread Robin Jarry
Hi Mattias, Mattias Rönnblom, Nov 29, 2022 at 17:10: > > + * @param [out] busy_cycles > > + * The number of busy CPU cycles since the application start. > > Wouldn't it be more appropriate to describe it as "TSC cycles", instead > of "CPU cycles"? Or technically "The amount of busy time since

Re: [PATCH v3 2/4] eal: allow applications to report their cpu cycles usage

2022-11-29 Thread Mattias Rönnblom
On 2022-11-29 16:33, Robin Jarry wrote: Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of CPU cycles that have passed since application start and the number of t