RE: [PATCH v4] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-04-09 Thread Ananyev, Konstantin
Hi Sean, > >> + > >> +/* Setup ACL context. 8< */ > > Looks like some typo within comments. > > I believe these characters are needed in the comments to state the start > and end of the automated code snippets for the docs. Ah ok, then please ignore 😊

Re: [PATCH v4] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-04-08 Thread Morrissey, Sean
Hi Konstantin, Comment on some of your feedback below. I will make the rest of the changes and send a new version. On 08/04/2022 18:26, Ananyev, Konstantin wrote: Hi Sean, Few nits, that I didn't spot previously, pls see below. + +/* Setup ACL context. 8< */ Looks like some typo within

RE: [PATCH v4] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-04-08 Thread Ananyev, Konstantin
Hi Sean, Few nits, that I didn't spot previously, pls see below. > l3fwd-acl contains duplicate functions to l3fwd. > For this reason we merge l3fwd-acl code into l3fwd > with '--lookup acl' cmdline option to run ACL. > > Signed-off-by: Sean Morrissey > --- > MAINTAINERS