Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-11 Thread Stephen Hemminger
On Thu, 11 Aug 2022 06:31:31 + Chaoyong He wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, August 11, 2022 12:25 PM > > To: Chaoyong He > > Cc: Andrew Rybchenko ; Niklas > > Soderlund ; dev@dpdk.org > > Subject

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Chaoyong He
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, August 11, 2022 12:25 PM > To: Chaoyong He > Cc: Andrew Rybchenko ; Niklas > Soderlund ; dev@dpdk.org > Subject: Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics > > On Thu,

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Stephen Hemminger
On Thu, 11 Aug 2022 01:26:49 + Chaoyong He wrote: > > > The 'port_id' is the 'Device [external] port identifier', which > > > related with the 'rte_ethdev_devices[]' I think. > > > Here the ethdev we created is not exposed to the user and is not in the > > 'rte_ethdev_devices[]' > > > arr

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Chaoyong He
> On Wed, 10 Aug 2022 01:51:55 + > Chaoyong He wrote: > > > > On Mon, 8 Aug 2022 11:32:30 + > > > Chaoyong He wrote: > > > > > > > > > + goto done; > > > > > > + > > > > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > > > > + hw->eth_dev = rte_zmalloc("ctrl_vn

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-10 Thread Stephen Hemminger
On Wed, 10 Aug 2022 01:51:55 + Chaoyong He wrote: > > On Mon, 8 Aug 2022 11:32:30 + > > Chaoyong He wrote: > > > > > > > + goto done; > > > > > + > > > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > > > + hw->eth_dev = rte_zmalloc("ctrl_vnic_eth_dev"

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-09 Thread Chaoyong He
> On Mon, 8 Aug 2022 11:32:30 + > Chaoyong He wrote: > > > > > + goto done; > > > > + > > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > > + hw->eth_dev = rte_zmalloc("ctrl_vnic_eth_dev", > > > > > > Why not rte_eth_dev_allocate()? Isn't an ethdev? > >

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-08 Thread Stephen Hemminger
On Mon, 8 Aug 2022 11:32:30 + Chaoyong He wrote: > > > + goto done; > > > + > > > + /* Allocate memory for the eth_dev of the vNIC */ > > > + hw->eth_dev = rte_zmalloc("ctrl_vnic_eth_dev", > > > > Why not rte_eth_dev_allocate()? Isn't an ethdev? > > Why do you bypsss ethdev layer i

RE: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-08 Thread Chaoyong He
> On 8/5/22 09:32, Chaoyong He wrote: > > This commit adds the setup/start logic for the ctrl vNIC. This vNIC > > "This commit adds" -> "Add" > > > is used by the PMD and flower firmware as a communication channel > > between driver and firmware. In the case of OVS it is also used to > > communic

Re: [PATCH v5 07/12] net/nfp: add flower ctrl VNIC related logics

2022-08-05 Thread Andrew Rybchenko
On 8/5/22 09:32, Chaoyong He wrote: This commit adds the setup/start logic for the ctrl vNIC. This vNIC "This commit adds" -> "Add" is used by the PMD and flower firmware as a communication channel between driver and firmware. In the case of OVS it is also used to communicate flow statistics