RE: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-05 Thread Wathsala Wathawana Vithanage
ect: Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints > API > > On Wed, Jun 04, 2025 at 10:52:24PM +, Wathsala Wathawana Vithanage > wrote: > > > > rte_pci_tph_st_{get, set} functions will return an error if > > > > processing any of th

RE: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-05 Thread Wathsala Wathawana Vithanage
ect: Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints > API > > On Wed, Jun 04, 2025 at 10:52:24PM +, Wathsala Wathawana Vithanage > wrote: > > > > rte_pci_tph_st_{get, set} functions will return an error if > > > > processing any of th

Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-05 Thread Bruce Richardson
On Mon, Jun 02, 2025 at 10:38:02PM +, Wathsala Vithanage wrote: > Extend the PCI bus driver to enable or disable TPH capability and set or > get PCI Steering-Tags (STs) on an endpoint device. The functions > rte_pci_tph_{enable, disable,st_set,st_get} provide the primary > interface for DPDK de

Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-05 Thread Bruce Richardson
On Wed, Jun 04, 2025 at 10:52:24PM +, Wathsala Wathawana Vithanage wrote: > > > rte_pci_tph_st_{get, set} functions will return an error if > > > processing any of the rte_tph_info objects fails. The API does not > > > indicate which entry in the rte_tph_info array was executed > > > successful

Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-05 Thread Bruce Richardson
On Wed, Jun 04, 2025 at 10:52:24PM +, Wathsala Wathawana Vithanage wrote: > > > rte_pci_tph_st_{get, set} functions will return an error if processing > > > any of the rte_tph_info objects fails. The API does not indicate which > > > entry in the rte_tph_info array was executed successfully and

RE: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-04 Thread Wathsala Wathawana Vithanage
> > rte_pci_tph_st_{get, set} functions will return an error if processing > > any of the rte_tph_info objects fails. The API does not indicate which > > entry in the rte_tph_info array was executed successfully and which > > caused an error. Therefore, in case of an error, the caller should > > di

Re: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-04 Thread Bruce Richardson
On Mon, Jun 02, 2025 at 10:38:02PM +, Wathsala Vithanage wrote: > Extend the PCI bus driver to enable or disable TPH capability and set or > get PCI Steering-Tags (STs) on an endpoint device. The functions > rte_pci_tph_{enable, disable,st_set,st_get} provide the primary > interface for DPDK de

RE: [PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-03 Thread Morten Brørup
> From: Wathsala Vithanage [mailto:wathsala.vithan...@arm.com] > Sent: Tuesday, 3 June 2025 00.38 Some nitpicking inline below. [...] > diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c > index 5e2e09d5a4..dff750c4d6 100644 > --- a/drivers/bus/pci/bsd/pci.c > +++ b/drivers/bus/p