RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, > Nope, it looks like we have a misunderstanding here. Looking back at my > comments from V3: What I meant is that the configuration values related to > this feature (all the tc_ov configuration values) should be computed at > initialization regardless of whether this feature is enabl

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, > > > > Still only changes in rte_sched.c and no change in rte_sched.h for the API > to > > configure this feature? > > Yes, because you said to remove whole > rte_sched_subport_tc_ov_config(struct rte_sched_port *port, > uint32_t subport_id, > bool tc_ov_enable) > here

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, Please find inline answers: > > History: > > - v1 - TC OV disabled by default > > - v2 - throughput improvements > > - v3, v4, v5 - changes from comments > > - v6 - removed rte_sched_subport_tc_ov_config declaration and map > > - v7 - changes from comments on v6 > > I see you moved

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 12:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v7] sched: enable traffic class oversubscription conditionally >