Re: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

2024-03-19 Thread Stephen Hemminger
On Tue, 12 Mar 2024 15:42:12 + Yoan Picchi wrote: > + static_assert(sizeof(*hitmask_buffer) >= 2*(RTE_HASH_BUCKET_ENTRIES/8), Space around math operations please.

RE: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

2024-03-19 Thread Konstantin Ananyev
> > > > Hi, > > > >> Current hitmask includes padding due to Intel's SIMD > >> implementation detail. This patch allows non Intel SIMD > >> implementations to benefit from a dense hitmask. > >> In addition, the new dense hitmask interweave the primary > >> and secondary matches which allow a bett

Re: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

2024-03-19 Thread Yoan Picchi
On 3/19/24 10:41, Konstantin Ananyev wrote: Hi, Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which al

RE: [PATCH v7 1/4] hash: pack the hitmask for hash in bulk lookup

2024-03-19 Thread Konstantin Ananyev
Hi, > Current hitmask includes padding due to Intel's SIMD > implementation detail. This patch allows non Intel SIMD > implementations to benefit from a dense hitmask. > In addition, the new dense hitmask interweave the primary > and secondary matches which allow a better cache usage and > enabl