RE: [PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-21 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, February 21, 2022 5:06 PM > Subject: Re: [PATCH v8 02/11] ethdev: add flow item/action templates > > On 2/21/22 16:12, Ori Kam wrote: > > Hi Andrew, > > > >> -Original M

RE: [PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-21 Thread Alexander Kozyrev
On Monday, February 21, 2022 8:12 Ori Kam wrote: > > See notes about order of checks in previous patch review notes. I'll fix order of checks in all patches, thank you for the suggestion. > > Would it be useful to mentioned that at least one direction > > bit must be set? Otherwise request does

Re: [PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-21 Thread Andrew Rybchenko
On 2/21/22 16:12, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, February 21, 2022 12:57 PM Subject: Re: [PATCH v8 02/11] ethdev: add flow item/action templates On 2/20/22 06:44, Alexander Kozyrev wrote: Treating every single flow rule as a

RE: [PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-21 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, February 21, 2022 12:57 PM > Subject: Re: [PATCH v8 02/11] ethdev: add flow item/action templates > > On 2/20/22 06:44, Alexander Kozyrev wrote: > > Treating every single flow rule as a co

Re: [PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-21 Thread Andrew Rybchenko
On 2/20/22 06:44, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can b