Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-06 Thread fengchengwen
On 2023/2/6 15:36, Morten Brørup wrote: >> From: fengchengwen [mailto:fengcheng...@huawei.com] >> Sent: Monday, 6 February 2023 05.00 >> >> Hi Robin, >> >> On 2023/2/2 21:43, Robin Jarry wrote: >>> Allow applications to register a callback that will be invoked in >>> rte_lcore_dump() and when reque

Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-06 Thread Robin Jarry
David Marchand, Feb 06, 2023 at 09:48: > +struct rte_lcore_usage { > + /** The total amount of time since application start, in TSC cycles. */ > + uint64_t total_cycles; This code comment needs some clarification. What is this "total amount of time"? "application start" is ambiguou

Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-06 Thread David Marchand
Hello Robin, On Thu, Feb 2, 2023 at 2:44 PM Robin Jarry wrote: > > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since app

Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-06 Thread Robin Jarry
Morten Brørup, Feb 06, 2023 at 08:36: > The 'record_burst_stats' also important for performance tune. While I agree that burst size spread is important for comparing CPU usage and capacity, the 'record_burst_stats' is a test_pmd specific feature. Applications may implement something different.

RE: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-05 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Monday, 6 February 2023 05.00 > > Hi Robin, > > On 2023/2/2 21:43, Robin Jarry wrote: > > Allow applications to register a callback that will be invoked in > > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > >

Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-05 Thread fengchengwen
Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start an