Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-28 Thread Bruce Richardson
On Tue, Feb 27, 2024 at 11:06:04AM -0800, Stephen Hemminger wrote: > On Tue, 27 Feb 2024 12:27:31 +0100 > Morten Brørup wrote: > > > > > 1. The extra 2 byte copy is effectively harmless due to padding, as > > > mentioned in the commit message. > > > > 2. The decorated rte_memcpy (if work on t

RE: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-28 Thread Raslan Darawsheh
; Subject: RE: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths > > +To: Raslan, regarding MLX5 patch > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Tuesday, 27 February 2024 12.01 > > > > On Mon, Feb 26, 2024 at 8:17 PM Mort

Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-27 Thread Stephen Hemminger
On Tue, 27 Feb 2024 12:27:31 +0100 Morten Brørup wrote: > > > 1. The extra 2 byte copy is effectively harmless due to padding, as > > mentioned in the commit message. > > > 2. The decorated rte_memcpy (if work on that patch series is ever > > > resumed) > > is an improvement, not a bug fix

RE: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-27 Thread Morten Brørup
+To: Raslan, regarding MLX5 patch > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, 27 February 2024 12.01 > > On Mon, Feb 26, 2024 at 8:17 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Monday, 26 February 2024 09.34 > > > > >

Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-27 Thread Jerin Jacob
On Mon, Feb 26, 2024 at 8:17 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Monday, 26 February 2024 09.34 > > > > On Fri, Feb 23, 2024 at 7:30 PM Morten Brørup > > wrote: > > > > > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only

Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-26 Thread Stephen Hemminger
On Fri, 23 Feb 2024 15:00:56 +0100 Morten Brørup wrote: > Bugfix: The vlan in the bulletin does not contain a VLAN header, only the > VLAN ID, so only copy 2 byte, not 4. The target structure has padding > after the field, so copying 2 byte too many is effectively harmless. > There is no need to

RE: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-26 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Monday, 26 February 2024 09.34 > > On Fri, Feb 23, 2024 at 7:30 PM Morten Brørup > wrote: > > > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only > the > > VLAN ID, so only copy 2 byte, not 4. The target structure ha

Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

2024-02-26 Thread Jerin Jacob
On Fri, Feb 23, 2024 at 7:30 PM Morten Brørup wrote: > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only the > VLAN ID, so only copy 2 byte, not 4. The target structure has padding > after the field, so copying 2 byte too many is effectively harmless. > There is no need to b