RE: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

> Subject: Re: [Patch v3 01/17] net/mana: add basic driver, build environment > and > doc > > On Thu, 7 Jul 2022 13:30:06 -0700 > lon...@linuxonhyperv.com wrote: > > > + file = fopen(path, "rb"); > > Minor nit, if you make any later changes. >

Re: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

On Thu, 7 Jul 2022 13:30:06 -0700 lon...@linuxonhyperv.com wrote: > +static int mana_pci_probe_mac(struct rte_pci_driver *pci_drv __rte_unused, > + struct rte_pci_device *pci_dev, > + struct rte_ether_addr *mac_addr) > +{ > + struct ibv_devi

Re: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

On Thu, 7 Jul 2022 13:30:06 -0700 lon...@linuxonhyperv.com wrote: > + file = fopen(path, "rb"); Minor nit, if you make any later changes. "rb" is same as "r" on Linux. b means binary, and this is actually a text file.