RE: [dpdk-dev] [PATCH] net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate

Hi, wenxu I'm sorry, it seems the mlx5_flow_tunnel_validate() routine had been already refactored and fixed, this patch is no longer relevant, With best regards, Slava > -Original Message- > From: dev On Behalf Of we...@ucloud.cn > Sent: Monday, August 9, 2021 8:44 > To: Gregory Etels

Re: [dpdk-dev] [PATCH] net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate

Hi, > Signed-off-by: wenxu Please could capitalize your name? Should it be split in 2 words? Convention in DPDK is to have first name first and family name at the end. Thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate

Hi, Winxu Thank you for the patch. > If the mlx5_flow_tunnel_validate validate the flow tunnel rule failed, the Typo? "validate" -> "validating" ? > err_msg is empty in the rte_flow_error. Sorry, what do you mean "empty"? It is NULL, not pointing to empty string "". Patch looks OK for me, could