RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Koikkara Reeny, Shibin
From: Maryam Tahhan Sent: Friday, December 1, 2023 10:20 AM To: Koikkara Reeny, Shibin ; ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
On 01/12/2023 10:31, Maryam Tahhan wrote: Yeah - I actually will remove the `--no-mlockall --in-memory` in the v2 respin (it's a typo). I'm only interested in showing the multiple af_xdp device (vdev) arguments. I think it's useful for anyone who is looking for a quick reference on how to do it

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
On 01/12/2023 10:26, David Marchand wrote: Hello, On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan wrote: [snip] diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst index a1a6d5b99c..a2d90c665d 100644 --- a/doc/guides/howto/af_xdp_cni.rst +++ b/doc/guides/howto/af_xdp_

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread David Marchand
Hello, On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan wrote: [snip] > diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst > index a1a6d5b99c..a2d90c665d 100644 > --- a/doc/guides/howto/af_xdp_cni.rst > +++ b/doc/guides/howto/af_xdp_cni.rst > @@ -38,9 +38,10 @@ The XSKMA

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
[snip] Prerequisites @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:    capabilities:   add:     - CAP_NET_RAW -       - CAP_BPF Why the CAP_BPF is removed?

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Koikkara Reeny, Shibin
Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni Hi Shibin No problem. Answer below. BR Maryam On 30/11/2023 13:56, Koikkara Reeny, Shibin wrote: Hi Maryam, I have one more question. Regards, Shibin -Original Message- From: Koikkara Reeny, Shibin

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
, 2023 12:14 PM To: Tahhan, Maryam ; ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org; Tahhan, Maryam Subject: RE: [v1] net/af_xdp: enable a sock path alongside use_cni Hi Maryam, I have added some suggestion below

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
; step...@networkplumber.org;lihuis...@huawei.com; fengcheng...@huawei.com;liuyongl...@huawei.com Cc:dev@dpdk.org; Tahhan, Maryam Subject: RE: [v1] net/af_xdp: enable a sock path alongside use_cni Hi Maryam, I have added some suggestion below. Regrads, Shibin [snip] Prerequisites @@ -224,7

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
awei.com; liuyongl...@huawei.com > Cc: dev@dpdk.org; Tahhan, Maryam > Subject: RE: [v1] net/af_xdp: enable a sock path alongside use_cni > > Hi Maryam, > > I have added some suggestion below. > > Regrads, > Shibin > > > -Original Message- > > From:

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
: [v1] net/af_xdp: enable a sock path alongside use_cni Hi Shibin Thanks for the review. Comments inline. BR Maryam On 30/11/2023 12:14, Koikkara Reeny, Shibin wrote: Hi Maryam, I have added some suggestion below. Regrads, Shibin [snip] NOTICE); #define UDS_MAX_CMD_LEN

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
Hi Shibin Thanks for the review. Comments inline. BR Maryam On 30/11/2023 12:14, Koikkara Reeny, Shibin wrote: Hi Maryam, I have added some suggestion below. Regrads, Shibin [snip] NOTICE); #define UDS_MAX_CMD_LEN 64 #define UDS_MAX_CMD_RESP 128 #d

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
Hi Maryam, I have added some suggestion below. Regrads, Shibin > -Original Message- > From: Maryam Tahhan > Sent: Thursday, November 30, 2023 9:14 AM > To: ferruh.yi...@amd.com; step...@networkplumber.org; > lihuis...@huawei.com; fengcheng...@huawei.com; > liuyongl...@huawei.com > Cc: d