RE: Service core statistics MT safety

2022-07-08 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, July 7, 2022 6:26 PM > To: Van Haaren, Harry ; Morten Brørup > ; Mattias Rönnblom ; > mattias.ronnblom ; dev@dpdk.org > Cc: nd ; nd > Subject: RE: Service core statistics MT safety > >

RE: Service core statistics MT safety

2022-07-07 Thread Honnappa Nagarahalli
> > > > > In my mind, any LTS/backports get the simplest/highest-confidence > > > bugfix: using > > > > atomics. > > > > The atomics are behind the "service stats" feature enable, so > > > > impact > > > is only > > > > when those are enabled. > > > > > > > > If there is still a performance hit,

RE: Service core statistics MT safety

2022-07-05 Thread Van Haaren, Harry
> -Original Message- > From: Morten Brørup > Sent: Friday, July 1, 2022 9:52 PM > To: Honnappa Nagarahalli ; Van Haaren, Harry > ; Mattias Rönnblom ; > mattias.ronnblom ; dev@dpdk.org > Cc: nd ; nd ; nd > Subject: RE: Service core statistics MT safety > >

RE: Service core statistics MT safety

2022-07-01 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, 1 July 2022 20.38 > > > > > > > > > > > > At the time of the read operation (in the global counter > solution), > > > > there may well be cycles consumed or calls having been made, but > not > > > > yet posted. Th

RE: Service core statistics MT safety

2022-07-01 Thread Honnappa Nagarahalli
> > > > > > At the time of the read operation (in the global counter solution), > > > there may well be cycles consumed or calls having been made, but not > > > yet posted. The window between call having been made, and global > > > counter having been incremented (and thus made globally visible

RE: Service core statistics MT safety

2022-06-30 Thread Van Haaren, Harry
; nd ; nd > > Subject: RE: Service core statistics MT safety > > > > At the time of the read operation (in the global counter solution), there > > may well > > be cycles consumed or calls having been made, but not yet posted. The window > > between cal

RE: Service core statistics MT safety

2022-06-29 Thread Honnappa Nagarahalli
> >> > >>> From: Mattias Rönnblom > >>> [mailto:mattias.ronnb...@ericsson.com] > >>> Sent: Monday, 27 June 2022 13.06 > >>> > >>> Hi. > >>> > >>> Is it safe to enable stats on MT safe services? > >>> > >>> https://prot

Re: Service core statistics MT safety

2022-06-28 Thread Mattias Rönnblom
On 2022-06-28 21:15, Honnappa Nagarahalli wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 27 June 2022 13.06 Hi. Is it safe to enable stats on MT safe services? https://protect2.fireeye.com/v1/url?k=31323334-501d5122- 313273af - 4 5444731-6096fdb1

RE: Service core statistics MT safety

2022-06-28 Thread Honnappa Nagarahalli
> > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Monday, 27 June 2022 13.06 > > > > Hi. > > > > Is it safe to enable stats on MT safe services? > > > > https://protect2.fireeye.com/v1/url?k=313233

Re: Service core statistics MT safety

2022-06-28 Thread Mattias Rönnblom
On 2022-06-28 17:24, Honnappa Nagarahalli wrote: > > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 27 June 2022 13.06 > > Hi. > > Is it safe to enable stats on MT safe services? > > https://

RE: Service core statistics MT safety

2022-06-28 Thread Honnappa Nagarahalli
> >> > >>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >>> Sent: Monday, 27 June 2022 13.06 > >>> > >>> Hi. > >>> > >>> Is it safe to enable stats on MT safe services? > >>> > >>> https://protect2.fireeye.com/v1/url?k=31323334-501d5122- > 31

Re: Service core statistics MT safety

2022-06-27 Thread Mattias Rönnblom
On 2022-06-28 02:14, Honnappa Nagarahalli wrote: > >> >>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >>> Sent: Monday, 27 June 2022 13.06 >>> >>> Hi. >>> >>> Is it safe to enable stats on MT safe services? >>> >>> https://protect2.fireeye.com/

RE: Service core statistics MT safety

2022-06-27 Thread Honnappa Nagarahalli
> > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Monday, 27 June 2022 13.06 > > > > Hi. > > > > Is it safe to enable stats on MT safe services? > > > > https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af- > 4 > > 54

Re: Service core statistics MT safety

2022-06-27 Thread Mattias Rönnblom
On 2022-06-27 20:19, Honnappa Nagarahalli wrote: > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 27 June 2022 13.06 > > Hi. > > Is it safe to enable stats on MT safe services? > > https://protect2.fireeye.com/v1/url?k=31323334-

RE: Service core statistics MT safety

2022-06-27 Thread Honnappa Nagarahalli
> >> > >>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >>> Sent: Monday, 27 June 2022 13.06 > >>> > >>> Hi. > >>> > >>> Is it safe to enable stats on MT safe services? > >>> > >>> https://github.com/DPDK/dpdk/blob/main/lib/eal/common/rte_service.c# > >>> L3 > >>> 6 > >>> 6 > >>

RE: Service core statistics MT safety

2022-06-27 Thread Honnappa Nagarahalli
> > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Monday, 27 June 2022 13.06 > > > > Hi. > > > > Is it safe to enable stats on MT safe services? > > > > https://github.com/DPDK/dpdk/blob/main/lib/eal/common/rte_service.c#L3 > > 6 > > 6 > > > > It seems to me this would

Re: Service core statistics MT safety

2022-06-27 Thread Mattias Rönnblom
On 2022-06-27 19:39, Honnappa Nagarahalli wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 27 June 2022 13.06 Hi. Is it safe to enable stats on MT safe services? https://github.com/DPDK/dpdk/blob/main/lib/eal/common/rte_service.c#L3 6 6 It seems to me thi

RE: Service core statistics MT safety

2022-06-27 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 27 June 2022 13.06 > > Hi. > > Is it safe to enable stats on MT safe services? > > https://github.com/DPDK/dpdk/blob/main/lib/eal/common/rte_service.c#L36 > 6 > > It seems to me this would have to be an __atomic_add