Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-16 Thread Stephen Hemminger
On Sat, 14 May 2022 18:14:48 +0100 Quentin Armitage wrote: > The final statement of pcapng_tsc_to_ns() should be: > return pcapng_time.ns + elapsed * TICK_SCALE; > > There is also a problem that rte_get_tsc_hz() returns eal_tsc_resolution_hz, > but > this is not initialized until rte_eal_

Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-14 Thread Quentin Armitage
On Wed, 2022-05-11 at 09:46 -0700, Stephen Hemminger wrote: > On Sat,  7 May 2022 17:12:36 +0100 > Quentin Armitage wrote: > > > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > > seconds after pcap_init is called when using a TSC with a frequency > > of 2.5GHz. > > > > To avoi

Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-11 Thread Stephen Hemminger
On Sat, 7 May 2022 17:12:36 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, reread the time and TSC once > delta * NSEC_PER_SEC > (1 <<

Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-11 Thread Stephen Hemminger
On Sat, 7 May 2022 17:12:36 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, reread the time and TSC once > delta * NSEC_PER_SEC > (1 <<