Re: [PATCH] net/gve: add support for basic stats

2023-02-03 Thread Ferruh Yigit
On 11/24/2022 7:33 AM, Junfeng Guo wrote: > Add support for dev_ops of stats_get and stats_reset. > > Queue stats update will be moved into xstat [1], but the basic stats > items may still be required. So we just keep the remaining ones and > will implement the queue stats via xstats in the coming

Re: [PATCH] net/gve: add support for basic stats

2023-02-02 Thread Joshua Washington
Tested-by: Joshua Washington On Tue, Jan 31, 2023 at 2:05 AM Ferruh Yigit wrote: > On 1/31/2023 1:51 AM, Joshua Washington wrote: > > Hello, > > > > I tested it out, and the updates to testpmd seem to work. > > > > Hi Joshua, > > Thanks for testing, I will send a patch soon. > > But this was te

Re: [PATCH] net/gve: add support for basic stats

2023-01-31 Thread Ferruh Yigit
On 1/31/2023 1:51 AM, Joshua Washington wrote: > Hello, > > I tested it out, and the updates to testpmd seem to work. > Hi Joshua, Thanks for testing, I will send a patch soon. But this was testpmd issue, do you have any objection with the net/gve patch, if not can you please record this with

Re: [PATCH] net/gve: add support for basic stats

2023-01-30 Thread Joshua Washington
Hello, I tested it out, and the updates to testpmd seem to work. Before applying the second patch: -- Forward statistics for port 0 -- RX-packets: 0 RX-dropped: 0 RX-total: 0 TX-packets: 43769238 TX-dropped: 62634

Re: [PATCH] net/gve: add support for basic stats

2023-01-18 Thread Ferruh Yigit
On 12/19/2022 7:38 PM, Joshua Washington wrote: > Hello, > > As it turns out, this error actually propagates to the "total" stats as > well, which I assume is just calculated by adding TX-packets and > TX-dropped. Here are the full stats from the example that Rushil mentioned: > >   -

Re: [PATCH] net/gve: add support for basic stats

2022-12-21 Thread Joshua Washington
Hello, As it turns out, this error actually propagates to the "total" stats as well, which I assume is just calculated by adding TX-packets and TX-dropped. Here are the full stats from the example that Rushil mentioned: -- Forward statistics for port 0 -

Re: [PATCH] net/gve: add support for basic stats

2022-12-19 Thread Rushil Gupta
Hi all Josh just found out some inconsistencies in the Tx/Rx statistics sum for all ports. Not sure if we can screenshot here but it goes like this: Tx-dropped for port0: 447034 Tx-dropped for port1: 0 Accumulated forward statistics for all ports: 807630 Please note that this issue is only with Tx

Re: [PATCH] net/gve: add support for basic stats

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 15:09:08 + Ferruh Yigit wrote: > On 11/24/2022 7:33 AM, Junfeng Guo wrote: > > Add support for dev_ops of stats_get and stats_reset. > > > > Queue stats update will be moved into xstat [1], but the basic stats > > items may still be required. So we just keep the remaining

Re: [PATCH] net/gve: add support for basic stats

2022-12-07 Thread Ferruh Yigit
On 11/24/2022 7:33 AM, Junfeng Guo wrote: > Add support for dev_ops of stats_get and stats_reset. > > Queue stats update will be moved into xstat [1], but the basic stats > items may still be required. So we just keep the remaining ones and > will implement the queue stats via xstats in the coming

RE: [PATCH] net/gve: add support for basic stats

2022-11-28 Thread Guo, Junfeng
> > Subject: Re: [PATCH] net/gve: add support for basic stats > > On Mon, 28 Nov 2022 11:12:38 + > Ferruh Yigit wrote: > > > On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > > > On Fri, 25 Nov 2022 19:16:00 -0800 > > > Rushil Gupta wrote: > > &g

Re: [PATCH] net/gve: add support for basic stats

2022-11-28 Thread Stephen Hemminger
On Mon, 28 Nov 2022 11:12:38 + Ferruh Yigit wrote: > On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > > On Fri, 25 Nov 2022 19:16:00 -0800 > > Rushil Gupta wrote: > > > > The driver should be filling in the per-queue stats as well. > q_ipackets, q_opackets, q_ibytes, q_oby

Re: [PATCH] net/gve: add support for basic stats

2022-11-28 Thread Ferruh Yigit
On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > On Fri, 25 Nov 2022 19:16:00 -0800 > Rushil Gupta wrote: > The driver should be filling in the per-queue stats as well. q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors >>> >>> >>> Hi Stephen, >>> >>> Queue stats moved to xsta

Re: [PATCH] net/gve: add support for basic stats

2022-11-26 Thread Stephen Hemminger
On Fri, 25 Nov 2022 19:16:00 -0800 Rushil Gupta wrote: > > > > > > The driver should be filling in the per-queue stats as well. > > > q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors > > > > > > Hi Stephen, > > > > Queue stats moved to xstats, and there is a long term goal to move all > > q

Re: [PATCH] net/gve: add support for basic stats

2022-11-25 Thread Rushil Gupta
Makes sense. On Thu, Nov 24, 2022 at 9:26 AM Ferruh Yigit wrote: > > On 11/24/2022 4:59 PM, Stephen Hemminger wrote: > > On Thu, 24 Nov 2022 15:33:35 +0800 > > Junfeng Guo wrote: > > > >> +static int > >> +gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > >> +{ > >> +

Re: [PATCH] net/gve: add support for basic stats

2022-11-24 Thread Ferruh Yigit
On 11/24/2022 4:59 PM, Stephen Hemminger wrote: > On Thu, 24 Nov 2022 15:33:35 +0800 > Junfeng Guo wrote: > >> +static int >> +gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> +{ >> +uint16_t i; >> + >> +for (i = 0; i < dev->data->nb_tx_queues; i++) { >> +

Re: [PATCH] net/gve: add support for basic stats

2022-11-24 Thread Stephen Hemminger
On Thu, 24 Nov 2022 15:33:35 +0800 Junfeng Guo wrote: > +static int > +gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + > + for (i = 0; i < dev->data->nb_tx_queues; i++) { > + struct gve_tx_queue *txq = dev->data->tx_queues[i]; >