Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-05-02 Thread Ferruh Yigit
On 2/21/2023 8:42 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > Change all the logging statements on the datapath to use RTE_LOG_DP() to > reduce CPU overhead when logging is not enabled for datapath. > > Fixes: 517ed6e2d5 ("net/mana: add basic driver with build environment") > Cc: sta

RE: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-04-28 Thread Long Li
>Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > >On 4/28/2023 2:29 AM, Long Li wrote: >> >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Friday, March 3, 2023 5:15 PM >>> To: Long Li ; Stephe

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-04-28 Thread Ferruh Yigit
; Jerin Jacob >> Kollanukkaran ; David Marchand >> ; dev@dpdk.org; Ajay Sharma >> ; sta...@dpdk.org; Luca Boccassi >> ; Qi Z Zhang ; Ajit Khaparde >> ; Bruce Richardson >> ; Konstantin Ananyev >> ; Olivier Matz ; >> Honnappa Nagarahalli ; techbo...@dpdk.org

RE: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-04-27 Thread Long Li
Sharma > ; sta...@dpdk.org; Luca Boccassi > ; Qi Z Zhang ; Ajit Khaparde > ; Bruce Richardson > ; Konstantin Ananyev > ; Olivier Matz ; > Honnappa Nagarahalli ; techbo...@dpdk.org > Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > > On 3/3/2023 7:04 PM,

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-03 Thread Ferruh Yigit
On 3/3/2023 7:04 PM, Long Li wrote: >> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath >> >> On 3/3/2023 2:16 AM, Long Li wrote: >>>> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath >>>> >>>> On Thu, 23

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-03 Thread Stephen Hemminger
On Fri, 3 Mar 2023 13:54:23 + Ferruh Yigit wrote: > On 3/3/2023 2:16 AM, Long Li wrote: > >> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > >> > >> On Thu, 23 Feb 2023 10:09:17 -0800 > >> Stephen Hemminger wrote: > >

RE: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-03 Thread Long Li
> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > > On 3/3/2023 2:16 AM, Long Li wrote: > >> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > >> > >> On Thu, 23 Feb 2023 10:09:17 -0800 > >> Stephen Hemminger w

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-03 Thread Ferruh Yigit
On 3/3/2023 2:16 AM, Long Li wrote: >> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath >> >> On Thu, 23 Feb 2023 10:09:17 -0800 >> Stephen Hemminger wrote: >> >>> On Thu, 23 Feb 2023 14:07:25 + >>> Ferruh Yigit wrote: >&g

RE: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-02 Thread Long Li
> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > > On Thu, 23 Feb 2023 10:09:17 -0800 > Stephen Hemminger wrote: > > > On Thu, 23 Feb 2023 14:07:25 + > > Ferruh Yigit wrote: > > > > > Overall I am not sure if anyone is inte

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-02-24 Thread Stephen Hemminger
On Thu, 23 Feb 2023 10:09:17 -0800 Stephen Hemminger wrote: > On Thu, 23 Feb 2023 14:07:25 + > Ferruh Yigit wrote: > > > Overall I am not sure if anyone is interested in driver datapath logs > > other than driver developers themselves. > > > > For datapath logging I think there are two con

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2023 14:07:25 + Ferruh Yigit wrote: > Overall I am not sure if anyone is interested in driver datapath logs > other than driver developers themselves. > > For datapath logging I think there are two concerns, > 1) It should not eat *any* cycles unless explicitly enabled > 2) Ca

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-02-23 Thread Ferruh Yigit
On 2/21/2023 8:42 PM, lon...@linuxonhyperv.com wrote: > diff --git a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c > index 300bf27cc1..a45b5e289c 100644 > --- a/drivers/net/mana/tx.c > +++ b/drivers/net/mana/tx.c > @@ -183,17 +183,17 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf > **tx_pkts, ui