Re: [PATCH 00/21] replace strtok with strtok_r

2024-02-01 Thread David Marchand
On Tue, Nov 21, 2023 at 4:33 AM Jie Hai wrote: > > On 2023/11/15 23:08, Stephen Hemminger wrote: > > On Wed, 15 Nov 2023 12:27:37 +0100 > > Morten Brørup wrote: > > > just a final follow up, i can see that we already have a rte_strerror > here to do the replace with reentrant dance. it

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-20 Thread Jie Hai
On 2023/11/15 23:08, Stephen Hemminger wrote: On Wed, 15 Nov 2023 12:27:37 +0100 Morten Brørup wrote: just a final follow up, i can see that we already have a rte_strerror here to do the replace with reentrant dance. it is probably good to follow the already established pattern for this and ha

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-15 Thread Stephen Hemminger
On Wed, 15 Nov 2023 12:27:37 +0100 Morten Brørup wrote: > > > just a final follow up, i can see that we already have a rte_strerror > > > here to do the replace with reentrant dance. it is probably good to > > > follow the already established pattern for this and have a > > rte_strtok. > > > >

RE: [PATCH 00/21] replace strtok with strtok_r

2023-11-15 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 15 November 2023 04.03 > > On 2023/11/15 1:49, Tyler Retzlaff wrote: > > On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: > >> On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > >>> On Tue, Nov 1

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread fengchengwen
On 2023/11/15 1:49, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: >> On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: >>> On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: On 2023/11/14 1:09, Tyler Retzlaff wrote: > On Mon, No

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > > On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > > > On 2023/11/14 1:09, Tyler Retzlaff wrote: > > > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wro

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > > On 2023/11/14 1:09, Tyler Retzlaff wrote: > > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > > >>Multiple threads calling the same function may cause condition

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > On 2023/11/14 1:09, Tyler Retzlaff wrote: > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > >>Multiple threads calling the same function may cause condition > >>race issues, which often leads to abnormal behavior and can cause >

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Jie Hai
On 2023/11/14 1:09, Tyler Retzlaff wrote: On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: Multiple threads calling the same function may cause condition race issues, which often leads to abnormal behavior and can cause more serious vulnerabilities such as abnormal termination, denial of

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integr

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-13 Thread fengchengwen
Hi Jie, Good fix There are two minor I think need to modify: 1. The [PATCH 13/21] lib/telemetry should be lib/security 2. All commits should add Cc because it's potential bug. The other LGTM, with above fixed Series-acked-by: Chengwen Feng Thanks Chengwen On 2023/11/13 18:45, Jie Hai wrote: >

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-13 Thread Thomas Monjalon
13/11/2023 11:45, Jie Hai: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. > > The strtok() is non-