Re: [PATCH 2/5] dts: skip first line of send_command output

2024-06-14 Thread Nicholas Pratte
> > > >> @@ -132,6 +135,9 @@ def send_command(self, command: str, prompt: str | > > > >> None = None) -> str: > > > >> self._stdin.flush() > > > >> out: str = "" > > > >> for line in self._stdout: > > > >> +if skip_first_line: > > > >> +sk

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-04-29 Thread Jeremy Spewock
Apologies for the complications that this interactive shell provides here. These problems didn't arise previously primarily because the interactive shells were designed to receive commands, give you the raw output, and then the developer extract specifically what they want from the output and ignor

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-04-17 Thread Juraj Linkeš
On Tue, Apr 16, 2024 at 2:15 PM Luca Vizzarro wrote: > > On 16/04/2024 09:48, Juraj Linkeš wrote: > > Oh, the first commit message was confusing. It said leading prompt > > which I understood to be the first prompt (the one with the command). > > I see that this commit actually addresses what I th

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-04-16 Thread Luca Vizzarro
On 16/04/2024 09:48, Juraj Linkeš wrote: Oh, the first commit message was confusing. It said leading prompt which I understood to be the first prompt (the one with the command). I see that this commit actually addresses what I thought the first commit was trying to do. Yes, my bad! -def s

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-04-16 Thread Juraj Linkeš
On Fri, Apr 12, 2024 at 1:11 PM Luca Vizzarro wrote: > > The first line of the InteractiveShell send_command method is generally > the command input field. This sometimes is unwanted, therefore this > commit enables the possibility of omitting the first line from the > returned output. > Oh, the