Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread Ajit Khaparde
On Mon, Nov 15, 2021 at 8:58 PM Somnath Kotur wrote: > > On Mon, Nov 15, 2021 at 2:58 PM David Marchand > wrote: > > > > Hello Ajit, Somnath, > > > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > > > > > This patch fixes unused but set variables in the following net drivers: > > > - bn

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread Somnath Kotur
On Mon, Nov 15, 2021 at 2:58 PM David Marchand wrote: > > Hello Ajit, Somnath, > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > > > This patch fixes unused but set variables in the following net drivers: > > - bnxt > > - hinic > > - liquidio > > - nfp > > - octeontx > > - qede > >

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread David Marchand
Hello Ajit, Somnath, On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > This patch fixes unused but set variables in the following net drivers: > - bnxt > - hinic > - liquidio > - nfp > - octeontx > - qede > - txgbe > - vmxnet3 > > This patch also fixes an unused function warning for

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On Fri, 12 Nov 2021 16:38:37 + > "Walsh, Conor" wrote: > > > Would something along the lines of this make more sense? > > > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #else > > vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #endif > > > > Thanks

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Stephen Hemminger
On Fri, 12 Nov 2021 16:38:37 + "Walsh, Conor" wrote: > Would something along the lines of this make more sense? > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > #else > vmxnet3_unmap_pkt(tcd->txdIdx, txq); > #endif > > Thanks, > Conor. Why not ju

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables > > On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > > static void > > > vmxnet3_tq_tx_complete(vmxnet3_tx_que

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; > > struct Vmxnet3_TxCompDes

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread David Marchand
On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Ferruh Yigit
On 11/12/2021 2:01 PM, Conor Walsh wrote: static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) { + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX int completed = 0; + #endif vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; struct Vmxnet3_TxCompDesc *tcd = (st