Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-20 Thread David Marchand
On Tue, Feb 14, 2023 at 7:16 PM Ferruh Yigit wrote: > > On 1/24/2023 10:47 AM, David Marchand wrote: > > Reduce code duplication by introducing a helper that takes care of > > transmitting, retrying if enabled and incrementing tx counter. > > > > Signed-off-by: David Marchand > > <...> > > > diff

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-16 Thread Ferruh Yigit
On 2/16/2023 8:01 AM, Singh, Aman Deep wrote: > > On 2/14/2023 11:47 PM, Ferruh Yigit wrote: >> On 2/14/2023 11:03 AM, Singh, Aman Deep wrote: >>> On 1/24/2023 4:17 PM, David Marchand wrote: Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enab

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-16 Thread Singh, Aman Deep
On 2/14/2023 11:47 PM, Ferruh Yigit wrote: On 2/14/2023 11:03 AM, Singh, Aman Deep wrote: On 1/24/2023 4:17 PM, David Marchand wrote: Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enabled and incrementing tx counter. Signed-off-by: David Marchan

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-14 Thread Ferruh Yigit
On 2/14/2023 11:03 AM, Singh, Aman Deep wrote: > > On 1/24/2023 4:17 PM, David Marchand wrote: >> Reduce code duplication by introducing a helper that takes care of >> transmitting, retrying if enabled and incrementing tx counter. >> >> Signed-off-by: David Marchand <...> >> diff --git a/app/te

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-14 Thread Ferruh Yigit
On 1/24/2023 10:47 AM, David Marchand wrote: > Reduce code duplication by introducing a helper that takes care of > transmitting, retrying if enabled and incrementing tx counter. > > Signed-off-by: David Marchand <...> > diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c > index 9

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-14 Thread Singh, Aman Deep
On 1/24/2023 4:17 PM, David Marchand wrote: Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enabled and incrementing tx counter. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c| 22 + app/test-pmd/csumonly.c | 23 +--