Re: [PATCH v1 2/4] dts: add context manager for interactive shells

2024-05-29 Thread Jeremy Spewock
On Wed, May 22, 2024 at 9:53 AM Patrick Robb wrote: > > Reviewed-by: Patrick Robb > > I don't have any comments beyond Luca's suggestions, but saw the typo below. > > On Tue, May 14, 2024 at 4:15 PM wrote: > > +def __exit__(self, type: BaseException, value: BaseException, > > traceback: Tra

Re: [PATCH v1 2/4] dts: add context manager for interactive shells

2024-05-29 Thread Jeremy Spewock
On Mon, May 20, 2024 at 1:31 PM Luca Vizzarro wrote: > > On 14/05/2024 21:14, jspew...@iol.unh.edu wrote: > > +class CriticalInteractiveShell(InteractiveShell): > > > +_get_priviledged_command: Callable[[str], str] | None > typo: privileged Ack. > > + > > +def __init__( > > +sel

Re: [PATCH v1 2/4] dts: add context manager for interactive shells

2024-05-22 Thread Patrick Robb
Reviewed-by: Patrick Robb I don't have any comments beyond Luca's suggestions, but saw the typo below. On Tue, May 14, 2024 at 4:15 PM wrote: > +def __exit__(self, type: BaseException, value: BaseException, traceback: > TracebackType) -> None: > +"""Exit the context block. > + > +

Re: [PATCH v1 2/4] dts: add context manager for interactive shells

2024-05-20 Thread Luca Vizzarro
On 14/05/2024 21:14, jspew...@iol.unh.edu wrote: +class CriticalInteractiveShell(InteractiveShell): +_get_priviledged_command: Callable[[str], str] | None typo: privileged + +def __init__( +self, +interactive_session: SSHClient, +logger: DTSLogger, +ge