Re: [PATCH v10 06/21] hash/thash: remove use of VLAs for Windows built

2024-11-21 Thread Andre Muezerie
On Wed, Nov 20, 2024 at 10:40:07AM +, Medvedkin, Vladimir wrote: > Hi Andre, > > On 20/11/2024 03:13, Andre Muezerie wrote: > >From: Konstantin Ananyev > > > >1) ./lib/hash/rte_thash.c:774:9 > > : warning: ISO C90 forbids variable length array ‘tmp_tuple’ > > > > From my understanding, tup

Re: [PATCH v10 06/21] hash/thash: remove use of VLAs for Windows built

2024-11-20 Thread Medvedkin, Vladimir
Hi Andre, On 20/11/2024 03:13, Andre Muezerie wrote: From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to rep