Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-21 Thread Stephen Hemminger
On Tue, 21 May 2024 11:06:59 -0400 Aaron Conole wrote: > > > > If we can have an Ubuntu 24.04 environment, this addresses the libbpf > > testing concern. > > I think it would be good to add as well. 24.04 will be an LTS, so it > should be support for long time. > > > @Christian can comment b

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-21 Thread Aaron Conole
Ferruh Yigit writes: > On 5/21/2024 5:23 AM, Patrick Robb wrote: >> On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote: >>> >>> @Patric, I assume test environment also doesn't have 'libbpf', version: >>> '>= 1.0' which we need to test this feature. >>> Is it possible to update test environment t

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-21 Thread Patrick Robb
On Tue, May 21, 2024 at 9:47 AM Ferruh Yigit wrote: > > > If we can have an Ubuntu 24.04 environment, this addresses the libbpf > testing concern. > > @Christian can comment better, but as far as I can see although upgrade > from previous LTS is not supported yet, it is possible to install Ubuntu

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-21 Thread Ferruh Yigit
On 5/21/2024 5:23 AM, Patrick Robb wrote: > On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote: >> >> @Patric, I assume test environment also doesn't have 'libbpf', version: >> '>= 1.0' which we need to test this feature. >> Is it possible to update test environment to justify this dependency? >>

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Patrick Robb
On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote: > > @Patric, I assume test environment also doesn't have 'libbpf', version: > '>= 1.0' which we need to test this feature. > Is it possible to update test environment to justify this dependency? > Hi, the libbpf version on our Ubuntu 22.04 conta

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Stephen Hemminger
On Mon, 20 May 2024 23:08:04 +0100 Ferruh Yigit wrote: > > > > It can be done, but it is a _lot_ of work and requires a lot of shims, > > so for something optional it's not really worth it. Given libbpf 1.0 > > also broke ABI, Ubuntu 22.04 and older cannot really get a new version > > as it's in

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Luca Boccassi
On Mon, 20 May 2024 at 23:08, Ferruh Yigit wrote: > > On 5/20/2024 10:42 PM, Luca Boccassi wrote: > > On Mon, 20 May 2024 at 19:43, Stephen Hemminger > > wrote: > >> > >> On Mon, 20 May 2024 18:49:19 +0100 > >> Ferruh Yigit wrote: > >> > >>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote: >

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Ferruh Yigit
On 5/20/2024 10:42 PM, Luca Boccassi wrote: > On Mon, 20 May 2024 at 19:43, Stephen Hemminger > wrote: >> >> On Mon, 20 May 2024 18:49:19 +0100 >> Ferruh Yigit wrote: >> >>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote: There were multiple issues in the RSS queue support in the TAP dri

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Ferruh Yigit
On 5/20/2024 7:18 PM, Stephen Hemminger wrote: > On Mon, 20 May 2024 18:49:19 +0100 > Ferruh Yigit wrote: > >> On 5/2/2024 10:31 PM, Stephen Hemminger wrote: >>> There were multiple issues in the RSS queue support in the TAP >>> driver. This required extensive rework of the BPF support. >>> >>> C

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Luca Boccassi
On Mon, 20 May 2024 at 19:43, Stephen Hemminger wrote: > > On Mon, 20 May 2024 18:49:19 +0100 > Ferruh Yigit wrote: > > > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > > There were multiple issues in the RSS queue support in the TAP > > > driver. This required extensive rework of the BPF sup

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Stephen Hemminger
On Mon, 20 May 2024 18:49:19 +0100 Ferruh Yigit wrote: > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > There were multiple issues in the RSS queue support in the TAP > > driver. This required extensive rework of the BPF support. > > > > Change the BPF loading to use bpftool to > > create a

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-20 Thread Ferruh Yigit
On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > There were multiple issues in the RSS queue support in the TAP > driver. This required extensive rework of the BPF support. > > Change the BPF loading to use bpftool to > create a skeleton header file, and load with libbpf. > The BPF is always compi