Re: [PATCH v18 2/8] eal: add thread attributes

2022-02-05 Thread Tyler Retzlaff
On Sat, Feb 05, 2022 at 10:00:01AM +0100, Thomas Monjalon wrote: > 05/02/2022 05:41, Tyler Retzlaff: > > On Fri, Feb 04, 2022 at 07:21:10PM +, Ananyev, Konstantin wrote: > > > > +int > > > > +rte_thread_attr_init(rte_thread_attr_t *attr) > > > > +{ > > > > + RTE_VERIFY(attr != NULL); > >

RE: [PATCH v18 2/8] eal: add thread attributes

2022-02-05 Thread Ananyev, Konstantin
> > On Fri, Feb 04, 2022 at 07:21:10PM +, Ananyev, Konstantin wrote: > > > Implement thread attributes for: > > > * thread affinity > > > * thread priority > > > Implement functions for managing thread attributes. > > > > > > Priority is represented through an enum that allows for two levels

Re: [PATCH v18 2/8] eal: add thread attributes

2022-02-05 Thread Thomas Monjalon
05/02/2022 05:41, Tyler Retzlaff: > On Fri, Feb 04, 2022 at 07:21:10PM +, Ananyev, Konstantin wrote: > > > +int > > > +rte_thread_attr_init(rte_thread_attr_t *attr) > > > +{ > > > + RTE_VERIFY(attr != NULL); > > > > As a generic one, here and everywhere: > > Please don't use RTE_VERIFY() for c

Re: [PATCH v18 2/8] eal: add thread attributes

2022-02-04 Thread Tyler Retzlaff
On Fri, Feb 04, 2022 at 07:21:10PM +, Ananyev, Konstantin wrote: > > Implement thread attributes for: > > * thread affinity > > * thread priority > > Implement functions for managing thread attributes. > > > > Priority is represented through an enum that allows for two levels: > > - RTE_TH

Re: [PATCH v18 2/8] eal: add thread attributes

2022-02-04 Thread Ananyev, Konstantin
> Implement thread attributes for: > * thread affinity > * thread priority > Implement functions for managing thread attributes. > > Priority is represented through an enum that allows for two levels: > - RTE_THREAD_PRIORITY_NORMAL > - RTE_THREAD_PRIORITY_REALTIME_CRITICAL > > Affinit