Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-29 Thread Juraj Linkeš
On Tue, May 28, 2024 at 2:05 PM Luca Vizzarro wrote: > > On 24/05/2024 17:17, Patrick Robb wrote: > > Luca, I assume what you had in mind was we will run > > dts-check-format.sh, so including isort and pylama, as opposed to just > > mypy? Thanks. > I originally thought of mypy only, Juraj suggeste

Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-28 Thread Luca Vizzarro
On 24/05/2024 17:17, Patrick Robb wrote: Luca, I assume what you had in mind was we will run dts-check-format.sh, so including isort and pylama, as opposed to just mypy? Thanks. I originally thought of mypy only, Juraj suggested the dts-check-format. I guess it is a good suggestion, and we shoul

Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-24 Thread Patrick Robb
Series-reviewed-by: Patrick Robb As a reminder, once this is merged, UNH will add a CI job which runs mypy and reports its results to PW (only runs for patches with changes in dpdk/dts). Luca, I assume what you had in mind was we will run dts-check-format.sh, so including isort and pylama, as op

Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-24 Thread Nicholas Pratte
Disregard that last comment, it was a mistake on my end. Updating the dependencies in my container instance fixed the problem. On Tue, May 21, 2024 at 10:59 AM Luca Vizzarro wrote: > > On 20/05/2024 16:37, Nicholas Pratte wrote: > > Ran into no issues with this when testing your port stats and in

Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-21 Thread Luca Vizzarro
On 20/05/2024 16:37, Nicholas Pratte wrote: Ran into no issues with this when testing your port stats and info patch, so I'll provide a tested tag as well. Other than a couple of issues listed in dts-check-format, everything looks good. This patch series should address all of the issues in dts

Re: [PATCH v2 0/2] dts: update mypy and clean up

2024-05-20 Thread Nicholas Pratte
Ran into no issues with this when testing your port stats and info patch, so I'll provide a tested tag as well. Other than a couple of issues listed in dts-check-format, everything looks good. Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Tue, May 14, 2024 at 7:34 AM Luca Vizzarro