Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-03-04 Thread Patrick Robb
Thanks Ariel, If you submitted another version that supersedes it, I think you need to mark this superseded: https://patchwork.dpdk.org/project/dpdk/patch/20250223214123.447579-2-ariel.otilib...@6wind.com/ Best, Patrick

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-26 Thread Ariel Otilibili
Hello Patrick, On Tue, Feb 25, 2025 at 9:42 PM Patrick Robb wrote: > Recheck-request: iol-marvell-Functional > > Putting in a recheck as I believe the fail CI reported is false. > >> >> Thanks for the heads up. This patch did supersede version 2, https://patches.dpdk.org/project/dpdk/patch/20250

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-25 Thread Patrick Robb
Recheck-request: iol-marvell-Functional Putting in a recheck as I believe the fail CI reported is false. On Sun, Feb 23, 2025 at 4:41 PM Ariel Otilibili wrote: > rte_pcapng_close() might dereference a null pointer; as example, > PVS-Studio gives its usage in test_pcapng.c: indeed, that call to

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-24 Thread Ariel Otilibili
Hello Dmitry, hello Stephen; On Mon, Feb 24, 2025 at 4:42 PM Stephen Hemminger < step...@networkplumber.org> wrote: > The convention (back from Unix) is that errno is only set on failure. > Simpler fix would just to silently ignore NULL case. > Thanks for your feedback. Here they are addressed,

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-24 Thread Stephen Hemminger
On Sun, 23 Feb 2025 22:41:23 +0100 Ariel Otilibili wrote: > rte_pcapng_close() might dereference a null pointer; as example, > PVS-Studio gives its usage in test_pcapng.c: indeed, that call to > rte_pcapng_close() might receive a null pointer. > > In that case, rte_errno is set to EINVAL. The AP

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-23 Thread Dmitry Kozlyuk
2025-02-23 22:41 (UTC+0100), Ariel Otilibili: > diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c > index 16485b27cb46..d2cbcea42885 100644 > --- a/lib/pcapng/rte_pcapng.c > +++ b/lib/pcapng/rte_pcapng.c > @@ -716,6 +716,9 @@ rte_pcapng_fdopen(int fd, > void > rte_pcapng_close(rte_pc