Re: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-02-07 Thread Maxime Coquelin
On 1/30/23 15:25, David Marchand wrote: On Mon, Jan 30, 2023 at 10:46 AM Maxime Coquelin wrote: On 1/29/23 10:25, David Marchand wrote: On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin wrote: On failure, read_vhost_message() only closed the message FDs if the header size was unexpected

RE: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-02-06 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Saturday, January 28, 2023 12:56 AM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Coquelin, Maxime ; sta...@dpdk.org > Subject: [PATCH v2 1/2] vhost: fix possible FDs leak > > On failure, read_vhost_message() onl

Re: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-01-30 Thread David Marchand
On Mon, Jan 30, 2023 at 10:46 AM Maxime Coquelin wrote: > > > > On 1/29/23 10:25, David Marchand wrote: > > On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin > > wrote: > >> > >> On failure, read_vhost_message() only closed the message > >> FDs if the header size was unexpected, but there are other

Re: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-01-30 Thread Maxime Coquelin
On 1/29/23 10:25, David Marchand wrote: On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin wrote: On failure, read_vhost_message() only closed the message FDs if the header size was unexpected, but there are other cases where it is required. For exemple in the case the payload size read from t

Re: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-01-29 Thread David Marchand
On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin wrote: > > On failure, read_vhost_message() only closed the message > FDs if the header size was unexpected, but there are other > cases where it is required. For exemple in the case the > payload size read from the header is greater than the > expec